Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement FromStr for CompressionType #167

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

LesnyRumcajs
Copy link
Contributor

Added FromStr for CompressionType

This is useful for clients with compression type adjustable via, e.g., a config file or CLI flag.

Copy link
Contributor

@Tpt Tpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It looks great to me! We have a "two reviewers" policy so we need to wait for an other approval before merge.

@Tpt Tpt requested review from cheme and arkpar December 14, 2022 17:46
Copy link
Collaborator

@cheme cheme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks.

@arkpar arkpar merged commit ca1625a into paritytech:master Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants