IndexTable::find_entry: add assertion bound checking #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to avoid a bound check on each `read_entry` call
arkpar
approved these changes
Jan 30, 2023
cheme
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
Did not see the linked issue the other day, makes sense. Probably not needed for plan_insert_chunk (buffer size known).
Maybe a comment would be good, no comment alternative would be to change chunk parameter to &[u8; CHUNK_SIZE] and unsafe cast before calling find_entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to avoid a bound check on each
read_entrycall