Preserve logs on write error. #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
commented
Mar 7, 2023
| @@ -867,7 +867,6 @@ pub struct Db { | |||
| flush_thread: Option<thread::JoinHandle<()>>, | |||
| log_thread: Option<thread::JoinHandle<()>>, | |||
| cleanup_thread: Option<thread::JoinHandle<()>>, | |||
| join_on_shutdown: bool, | |||
There was a problem hiding this comment.
Removed is since it is not very useful. Each thead is an Option anyway. the only thing it prevented is calling kill_logs on shutdown. Which is what the test actually requires.
Tpt
approved these changes
Mar 7, 2023
cheme
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a potential DB corruption on write error. When the database is closed with an error, all existing logs must be preserved so that log recovery may fix it on next open.