Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix find_entry_sse #193

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Fix find_entry_sse #193

merged 3 commits into from
Mar 20, 2023

Conversation

arkpar
Copy link
Member

@arkpar arkpar commented Mar 20, 2023

In case there are multiple matches for the first group of 4 etries, the sub_index check logic would only consider the first match.

cheme
cheme approved these changes Mar 20, 2023
View reviewed changes
src/index.rs Show resolved Hide resolved
MattHalpinParity
MattHalpinParity approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@MattHalpinParity MattHalpinParity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@arkpar arkpar merged commit edeae05 into master Mar 20, 2023
@arkpar arkpar deleted the arkpar/find_entry branch March 20, 2023 16:05
@Tpt
Copy link
Contributor

Tpt commented Mar 20, 2023

@arkpar Thank you! Sorry for introducing this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheme cheme cheme approved these changes

@MattHalpinParity MattHalpinParity MattHalpinParity approved these changes

@Tpt Tpt Awaiting requested review from Tpt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arkpar @Tpt @cheme @MattHalpinParity