Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix find_entry for zero partial key #206

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Fix find_entry for zero partial key #206

merged 2 commits into from
Apr 28, 2023

Conversation

arkpar
Copy link
Member

@arkpar arkpar commented Apr 24, 2023

In rare cases when target partial key is all zeroes and the index chunk contains precceding empty entries, these empty entries are returned instead.

@arkpar arkpar changed the title Fix find_entry for empty partial key Fix find_entry for zero partial key Apr 24, 2023
cheme
cheme approved these changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@cheme cheme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I guess it is better to check this than test address when checking, maybe could be detected afterward, not sure if it would make a difference)

MattHalpinParity
MattHalpinParity approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@MattHalpinParity MattHalpinParity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@arkpar arkpar merged commit 8be1523 into master Apr 28, 2023
@arkpar arkpar deleted the arkpar/fix-find-entry branch April 28, 2023 10:09
@cheme cheme mentioned this pull request Jun 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheme cheme cheme approved these changes

@MattHalpinParity MattHalpinParity MattHalpinParity approved these changes

@Tpt Tpt Awaiting requested review from Tpt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arkpar @cheme @MattHalpinParity