Force alignment for all chunk buffers #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheme
approved these changes
Oct 6, 2023
src/index.rs
Outdated
|
|
||
| pub type Chunk = [u8; CHUNK_LEN]; | ||
| #[repr(C, align(8))] | ||
| #[derive(PartialEq, Eq, Clone, Copy, Debug)] |
There was a problem hiding this comment.
Is the impact of not being Copy big ? (but not sure if we want to force explicit clone here).
There was a problem hiding this comment.
Made it explicit. Also changed transmute_chunk to operate on references, as it allows to eliminate a copy in some places.
| @@ -35,3 +35,6 @@ pub type Key = [u8; KEY_SIZE]; | |||
|
|
|||
| #[cfg(not(any(target_arch = "x86_64", target_arch = "aarch64")))] | |||
| compile_error!("parity-db only supports x86_64 and aarch64"); | |||
|
|
|||
| #[cfg(not(target_endian = "little"))] | |||
| compile_error!("parity-db only supports little-endian platforms"); | |||
There was a problem hiding this comment.
Make sense (keeping support would require a CI test indeed).
There was a problem hiding this comment.
Yeah, it is not tested properly. The platform restriction of x86_64 and aarch64 limits it to little endian anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #223