This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
Pull request needs code review.
A1-onice 🌨
Pull request is reviewed well, but should not yet be merged.
M0-build 🏗
Building and build system.
B0-patch
labels
Feb 9, 2018
it is necessary to check in |
Thanks so much, this was actually on my agenda. Best way to test this is merge and bump nightly, so I agree with @General-Beck here. |
Yup, sure. Just wait for the new updater to be deployed. |
Or actually, let me tag this PR once it's deployed. Any ETA? |
@5chdn only
|
tomusdrw
removed
the
A1-onice 🌨
Pull request is reviewed well, but should not yet be merged.
label
Feb 12, 2018
cc @fevo1971 |
5chdn
added
the
P2-asap 🌊
No need to stop dead in your tracks, however issue should be addressed as soon as possible.
label
Feb 12, 2018
This fail is probably related: https://gitlab.parity.io/parity/parity/-/jobs/78627
|
This probably too: https://gitlab.parity.io/parity/parity/-/jobs/78631
|
5chdn
added
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Feb 13, 2018
5chdn
approved these changes
Feb 13, 2018
5chdn
removed
the
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
label
Feb 13, 2018
This was referenced Feb 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A8-looksgood 🦄
Pull request is reviewed well.
M0-build 🏗
Building and build system.
P2-asap 🌊
No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should go after paritytech/push-release#9 is deployed.
BUILD_PLATFORM
instead of genericPLATFORM
when pushing build to updater.