This repository has been archived by the owner on Apr 2, 2020. It is now read-only.
Validation #9
Merged
Validation #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngotchac
reviewed
Feb 12, 2018
| @@ -140,12 +154,9 @@ app.post('/push-build/:tag/:platform', handleAsync(async function (req, res) { | |||
| console.log(`Track: ${branch} => ${track} (${tracks[track]}) [enabled: ${!!enabledTracks[track]}]`); | |||
|
|
|||
| if (!enabledTracks[track]) { | |||
| throw new Error(`Track not enabled: ${track}`); | |||
| throw boom.accepted(`Track not enabled: ${track}`); | |||
There was a problem hiding this comment.
That's not an error, right? Why using boom as such? You could just use res to send an early response.
There was a problem hiding this comment.
It is an error, but I want to return a specific status code in such case. Also I want to separate validation&logic from dealing with req/res directly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #8