Prevent Rust feature bleed

[ggwpez]

See paritytech/substrate#12341 for a description of the new script.

Currently working in Substrate: success case and error case.

[bkchr]

@mordamax you are fine with maintaining this? My eyes bleed again a little bit after seeing this bash script.

[bkchr]

BTW, there also exist this pr: paritytech/diener#19

[mordamax]

@mordamax you are fine with maintaining this? My eyes bleed again a little bit after seeing this bash script.

I guess it's @paritytech-ci who maintain it in this case.
This repo is mainly for reusable CI scripts, to avoid dupe

but my opinion is that it's okay as long as it's relevantly simple, <=~100 lines, otherwise it should be some more maintainable/readable language like ts/python/rust

the existing stuff like check-dependent should be killed 100%
tryruntime and bench most probably will be moved & rewritten to command bot

[ggwpez]

BTW, there also exist this pr: paritytech/diener#19

Interesting... I dont think parsing Cargo.toml files works for external dependencies from crates.io, or? (In case we ever release Substrate there 🤣) But in any case, that check is additive to this one.

I am not happy with this as long-term solution, but for now it should prevent obvious blunders which can take a while to find otherwise. Recently I saw https://github.com/guppy-rs/guppy which is used by Diem and think could be a fit.

[bkchr]

I dont think parsing Cargo.toml files works for external dependencies from crates.io, or

You download the deps to the local cargo registry. So, this should work.

Recently I saw https://github.com/guppy-rs/guppy which is used by Diem and think could be a fit.

I think I read about this somewhere before, but if that could be a fit, it would be nice.

[ggwpez]

Okay then lets use this to get rid of some obvious errors and then make a long-term strategy?
Like set out a scope of rules that we want to be checked and search for existing tools if they can do it or self implement.

[mutantcornholio]

I see three different approaches to checking return code here.
This one, inside if, then RET=0; command || RET=$?, and IS_NOT_SUPPORTED=$(command || echo $?).
Maybe put all of them into if's?

[ggwpez]

I kind of wanted to keep the lines short, but I guess I can break it into multiple like this as well 👍

[mutantcornholio]

anyway, much more readable and maintainable now, thank you!