Skip to content

Commit

Permalink
polkadot-node-core-pvf-common: Fix test compilation error (#5310)
Browse files Browse the repository at this point in the history
This crate only uses `tempfile` on linux but includes it unconditionally
in its `Cargo.toml`. It also sets `#![deny(unused_crate_dependencies)]`.
This leads to an hard error to anything that is not Linux.

This PR fixes this error. I am wondering why CI didn't catch that.
Shouldn't the test at least be compiled (but not run) on macOS?
  • Loading branch information
athei authored Aug 12, 2024
1 parent aca25a0 commit 8e8dc61
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions polkadot/node/core/pvf/common/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ seccompiler = "0.4.0"

[dev-dependencies]
assert_matches = { workspace = true }

[target.'cfg(target_os = "linux")'.dev-dependencies]
tempfile = { workspace = true }

[features]
Expand Down

0 comments on commit 8e8dc61

Please sign in to comment.