Skip to content

Commit

Permalink
[CI] Remove duplicate jobs (#5602)
Browse files Browse the repository at this point in the history
All of these things are already tested in Github Actions:
https://github.com/paritytech/polkadot-sdk/blob/b3c2a25b73bb4854f26204068f0aec3e8577196c/.github/workflows/checks-quick.yml#L50

Q: the `job-starter` seems to be used by tests, so am keeping it, but
not sure how useful it is.

---------

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Co-authored-by: alvicsam <alvicsam@gmail.com>
  • Loading branch information
3 people authored Sep 9, 2024
1 parent f5783cc commit a3eda0a
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 39 deletions.
26 changes: 26 additions & 0 deletions .github/workflows/checks-quick.yml
Original file line number Diff line number Diff line change
Expand Up @@ -181,3 +181,29 @@ jobs:
env:
ASSERT_REGEX: "FAIL-CI"
GIT_DEPTH: 1

confirm-required-checks-quick-jobs-passed:
runs-on: ubuntu-latest
name: All quick checks passed
# If any new job gets added, be sure to add it to this array
needs:
- fmt
- check-dependency-rules
- check-rust-feature-propagation
- test-rust-features
- check-toml-format
- check-workspace
- check-markdown
- check-umbrella
- check-fail-ci
if: always() && !cancelled()
steps:
- run: |
tee resultfile <<< '${{ toJSON(needs) }}'
FAILURES=$(cat resultfile | grep '"result": "failure"' | wc -l)
if [ $FAILURES -gt 0 ]; then
echo "### At least one required job failed ❌" >> $GITHUB_STEP_SUMMARY
exit 1
else
echo '### Good job! All the required jobs passed 🚀' >> $GITHUB_STEP_SUMMARY
fi
39 changes: 0 additions & 39 deletions .gitlab/pipeline/check.yml
Original file line number Diff line number Diff line change
@@ -1,25 +1,3 @@
# from substrate
# not sure if it's needed in monorepo
check-dependency-rules:
stage: check
extends:
- .kubernetes-env
- .test-refs-no-trigger-prs-only
variables:
CI_IMAGE: "paritytech/tools:latest"
allow_failure: true
script:
- cd substrate/
- ../.gitlab/ensure-deps.sh

test-rust-features:
stage: check
extends:
- .kubernetes-env
- .test-refs-no-trigger-prs-only
script:
- bash .gitlab/rust-features.sh .

job-starter:
stage: check
image: paritytech/tools:latest
Expand All @@ -29,20 +7,3 @@ job-starter:
allow_failure: true
script:
- echo ok

check-rust-feature-propagation:
stage: check
extends:
- .kubernetes-env
- .common-refs
script:
- zepter run check

check-toml-format:
stage: check
extends:
- .kubernetes-env
- .common-refs
script:
- taplo format --check --config .config/taplo.toml
- echo "Please run `taplo format --config .config/taplo.toml` to fix any toml formatting issues"

0 comments on commit a3eda0a

Please sign in to comment.