-
Notifications
You must be signed in to change notification settings - Fork 699
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Beefy: add benchmarks for
report_fork_voting() (#5188)
Related to #4523 This PR adds benchmarks for `report_fork_voting()`. **Important: Even though the benchmarks are now available, we still use `Weight::MAX`. That's because I realized while working on this PR that there's still one missing piece. We should also check that the ancestry proof is optimal. I plan to do this in a future PR, hopefully the last one related to #4523.** --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: command-bot <>
- Loading branch information
Showing
25 changed files
with
1,177 additions
and
630 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| // Copyright (C) Parity Technologies (UK) Ltd. | ||
| // This file is part of Polkadot. | ||
|
|
||
| // Polkadot is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
|
|
||
| // Polkadot is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU General Public License for more details. | ||
|
|
||
| // You should have received a copy of the GNU General Public License | ||
| // along with Polkadot. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| //! Autogenerated weights for `pallet_beefy_mmr` | ||
| //! | ||
| //! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 32.0.0 | ||
| //! DATE: 2024-08-13, STEPS: `50`, REPEAT: `20`, LOW RANGE: `[]`, HIGH RANGE: `[]` | ||
| //! WORST CASE MAP SIZE: `1000000` | ||
| //! HOSTNAME: `runner-696hpswk-project-674-concurrent-0`, CPU: `Intel(R) Xeon(R) CPU @ 2.60GHz` | ||
| //! WASM-EXECUTION: `Compiled`, CHAIN: `Some("rococo-dev")`, DB CACHE: 1024 | ||
|
|
||
| // Executed Command: | ||
| // target/production/polkadot | ||
| // benchmark | ||
| // pallet | ||
| // --steps=50 | ||
| // --repeat=20 | ||
| // --extrinsic=* | ||
| // --wasm-execution=compiled | ||
| // --heap-pages=4096 | ||
| // --json-file=/builds/parity/mirrors/polkadot-sdk/.git/.artifacts/bench.json | ||
| // --pallet=pallet_beefy_mmr | ||
| // --chain=rococo-dev | ||
| // --header=./polkadot/file_header.txt | ||
| // --output=./polkadot/runtime/rococo/src/weights/ | ||
|
|
||
| #![cfg_attr(rustfmt, rustfmt_skip)] | ||
| #![allow(unused_parens)] | ||
| #![allow(unused_imports)] | ||
| #![allow(missing_docs)] | ||
|
|
||
| use frame_support::{traits::Get, weights::Weight}; | ||
| use core::marker::PhantomData; | ||
|
|
||
| /// Weight functions for `pallet_beefy_mmr`. | ||
| pub struct WeightInfo<T>(PhantomData<T>); | ||
| impl<T: frame_system::Config> pallet_beefy_mmr::WeightInfo for WeightInfo<T> { | ||
| /// Storage: `System::BlockHash` (r:1 w:0) | ||
| /// Proof: `System::BlockHash` (`max_values`: None, `max_size`: Some(44), added: 2519, mode: `MaxEncodedLen`) | ||
| fn extract_validation_context() -> Weight { | ||
| // Proof Size summary in bytes: | ||
| // Measured: `92` | ||
| // Estimated: `3509` | ||
| // Minimum execution time: 7_116_000 picoseconds. | ||
| Weight::from_parts(7_343_000, 0) | ||
| .saturating_add(Weight::from_parts(0, 3509)) | ||
| .saturating_add(T::DbWeight::get().reads(1)) | ||
| } | ||
| /// Storage: `Mmr::Nodes` (r:1 w:0) | ||
| /// Proof: `Mmr::Nodes` (`max_values`: None, `max_size`: Some(40), added: 2515, mode: `MaxEncodedLen`) | ||
| fn read_peak() -> Weight { | ||
| // Proof Size summary in bytes: | ||
| // Measured: `234` | ||
| // Estimated: `3505` | ||
| // Minimum execution time: 5_652_000 picoseconds. | ||
| Weight::from_parts(5_963_000, 0) | ||
| .saturating_add(Weight::from_parts(0, 3505)) | ||
| .saturating_add(T::DbWeight::get().reads(1)) | ||
| } | ||
| /// Storage: `Mmr::RootHash` (r:1 w:0) | ||
| /// Proof: `Mmr::RootHash` (`max_values`: Some(1), `max_size`: Some(32), added: 527, mode: `MaxEncodedLen`) | ||
| /// Storage: `Mmr::NumberOfLeaves` (r:1 w:0) | ||
| /// Proof: `Mmr::NumberOfLeaves` (`max_values`: Some(1), `max_size`: Some(8), added: 503, mode: `MaxEncodedLen`) | ||
| /// The range of component `n` is `[2, 512]`. | ||
| fn n_items_proof_is_non_canonical(n: u32, ) -> Weight { | ||
| // Proof Size summary in bytes: | ||
| // Measured: `226` | ||
| // Estimated: `1517` | ||
| // Minimum execution time: 11_953_000 picoseconds. | ||
| Weight::from_parts(15_978_891, 0) | ||
| .saturating_add(Weight::from_parts(0, 1517)) | ||
| // Standard Error: 1_780 | ||
| .saturating_add(Weight::from_parts(1_480_582, 0).saturating_mul(n.into())) | ||
| .saturating_add(T::DbWeight::get().reads(2)) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| // Copyright (C) Parity Technologies (UK) Ltd. | ||
| // This file is part of Polkadot. | ||
|
|
||
| // Polkadot is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
|
|
||
| // Polkadot is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU General Public License for more details. | ||
|
|
||
| // You should have received a copy of the GNU General Public License | ||
| // along with Polkadot. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| //! Autogenerated weights for `pallet_beefy_mmr` | ||
| //! | ||
| //! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 32.0.0 | ||
| //! DATE: 2024-08-13, STEPS: `50`, REPEAT: `20`, LOW RANGE: `[]`, HIGH RANGE: `[]` | ||
| //! WORST CASE MAP SIZE: `1000000` | ||
| //! HOSTNAME: `runner-696hpswk-project-674-concurrent-0`, CPU: `Intel(R) Xeon(R) CPU @ 2.60GHz` | ||
| //! WASM-EXECUTION: `Compiled`, CHAIN: `Some("westend-dev")`, DB CACHE: 1024 | ||
|
|
||
| // Executed Command: | ||
| // target/production/polkadot | ||
| // benchmark | ||
| // pallet | ||
| // --steps=50 | ||
| // --repeat=20 | ||
| // --extrinsic=* | ||
| // --wasm-execution=compiled | ||
| // --heap-pages=4096 | ||
| // --json-file=/builds/parity/mirrors/polkadot-sdk/.git/.artifacts/bench.json | ||
| // --pallet=pallet_beefy_mmr | ||
| // --chain=westend-dev | ||
| // --header=./polkadot/file_header.txt | ||
| // --output=./polkadot/runtime/westend/src/weights/ | ||
|
|
||
| #![cfg_attr(rustfmt, rustfmt_skip)] | ||
| #![allow(unused_parens)] | ||
| #![allow(unused_imports)] | ||
| #![allow(missing_docs)] | ||
|
|
||
| use frame_support::{traits::Get, weights::Weight}; | ||
| use core::marker::PhantomData; | ||
|
|
||
| /// Weight functions for `pallet_beefy_mmr`. | ||
| pub struct WeightInfo<T>(PhantomData<T>); | ||
| impl<T: frame_system::Config> pallet_beefy_mmr::WeightInfo for WeightInfo<T> { | ||
| /// Storage: `System::BlockHash` (r:1 w:0) | ||
| /// Proof: `System::BlockHash` (`max_values`: None, `max_size`: Some(44), added: 2519, mode: `MaxEncodedLen`) | ||
| fn extract_validation_context() -> Weight { | ||
| // Proof Size summary in bytes: | ||
| // Measured: `92` | ||
| // Estimated: `3509` | ||
| // Minimum execution time: 7_850_000 picoseconds. | ||
| Weight::from_parts(8_169_000, 0) | ||
| .saturating_add(Weight::from_parts(0, 3509)) | ||
| .saturating_add(T::DbWeight::get().reads(1)) | ||
| } | ||
| /// Storage: `Mmr::Nodes` (r:1 w:0) | ||
| /// Proof: `Mmr::Nodes` (`max_values`: None, `max_size`: Some(40), added: 2515, mode: `MaxEncodedLen`) | ||
| fn read_peak() -> Weight { | ||
| // Proof Size summary in bytes: | ||
| // Measured: `201` | ||
| // Estimated: `3505` | ||
| // Minimum execution time: 6_852_000 picoseconds. | ||
| Weight::from_parts(7_448_000, 0) | ||
| .saturating_add(Weight::from_parts(0, 3505)) | ||
| .saturating_add(T::DbWeight::get().reads(1)) | ||
| } | ||
| /// Storage: `Mmr::RootHash` (r:1 w:0) | ||
| /// Proof: `Mmr::RootHash` (`max_values`: Some(1), `max_size`: Some(32), added: 527, mode: `MaxEncodedLen`) | ||
| /// Storage: `Mmr::NumberOfLeaves` (r:1 w:0) | ||
| /// Proof: `Mmr::NumberOfLeaves` (`max_values`: Some(1), `max_size`: Some(8), added: 503, mode: `MaxEncodedLen`) | ||
| /// The range of component `n` is `[2, 512]`. | ||
| fn n_items_proof_is_non_canonical(n: u32, ) -> Weight { | ||
| // Proof Size summary in bytes: | ||
| // Measured: `193` | ||
| // Estimated: `1517` | ||
| // Minimum execution time: 12_860_000 picoseconds. | ||
| Weight::from_parts(17_158_162, 0) | ||
| .saturating_add(Weight::from_parts(0, 1517)) | ||
| // Standard Error: 1_732 | ||
| .saturating_add(Weight::from_parts(1_489_410, 0).saturating_mul(n.into())) | ||
| .saturating_add(T::DbWeight::get().reads(2)) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0 | ||
| # See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json | ||
|
|
||
| title: Added benchmarks for BEEFY fork voting | ||
|
|
||
| doc: | ||
| - audience: | ||
| - Runtime Dev | ||
| - Runtime User | ||
| description: | | ||
| This PR adds benchmarks for `report_fork_voting` and `report_future_voting` extrinsics to `pallet-beefy`. | ||
| `report_future_voting` can be called now. `report_fork_voting` can't be called yet. Even though we have added | ||
| the formula for computing its weight, we still use `Weight::MAX`. We will set the proper weight in a future PR. | ||
| In order to do this we need to also check that the ancestry proof is optimal. | ||
| The PR adds a `WeightInfo` associated trait to the `pallet_beefy_mmr::Config` and defines benchmarks for | ||
| `pallet_beefy_mmr`. | ||
|
|
||
| crates: | ||
| - name: pallet-mmr | ||
| bump: minor | ||
| - name: sp-mmr-primitives | ||
| bump: minor | ||
| - name: sp-consensus-beefy | ||
| bump: minor | ||
| - name: rococo-runtime | ||
| bump: minor | ||
| - name: pallet-beefy | ||
| bump: major | ||
| - name: pallet-beefy-mmr | ||
| bump: major | ||
| - name: westend-runtime | ||
| bump: minor |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.