-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AllowTopLevelPaidExecutionFrom
barrier prevents multi currency transfers which also effects assethub
.
#1638
Comments
What was the motivation for limiting the |
To my understanding, it is indeed a security risk to allow unbounded asset withdrawal. But limit it to 1 is just too much, especially when the number is non configurable. |
@franciscoaguirre @KiChjang please look into this ASAP. |
Partially addresses #1638 Still need a better solution to allow devs to have better control of this. --------- Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Partially addresses paritytech#1638 Still need a better solution to allow devs to have better control of this. --------- Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Partially addresses #1638 Still need a better solution to allow devs to have better control of this. --------- Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
This issue has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/polkadot-release-analysis-v1-3-0/4614/1 |
This was fixed |
Is there an existing issue?
Experiencing problems? Have you tried our Stack Exchange first?
Description of bug
After this change,
AllowTopLevelPaidExecutionFrom
prevents multi currency transfers which also effectsassethub
; multi currency transfers are not possible anymore.Here, also, is a test case in the orml repo which failed after upgrading dependencies to
polkadot-v1.1.0
(which includes this change) and this is the solution for the problem, which is the exact copy of the old version of the barrier.Steps to reproduce
No response
The text was updated successfully, but these errors were encountered: