Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AllowTopLevelPaidExecutionFrom barrier prevents multi currency transfers which also effects assethub. #1638

Closed
2 tasks done
rimbi opened this issue Sep 19, 2023 · 5 comments
Closed
2 tasks done
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known. T6-XCM This PR/Issue is related to XCM.

Comments

@rimbi
Copy link
Contributor

rimbi commented Sep 19, 2023

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

After this change, AllowTopLevelPaidExecutionFrom prevents multi currency transfers which also effects assethub; multi currency transfers are not possible anymore.

Here, also, is a test case in the orml repo which failed after upgrading dependencies to polkadot-v1.1.0 (which includes this change) and this is the solution for the problem, which is the exact copy of the old version of the barrier.

Steps to reproduce

No response

@rimbi rimbi added I10-unconfirmed Issue might be valid, but it's not yet known. I2-bug The node fails to follow expected behavior. labels Sep 19, 2023
@librelois
Copy link
Contributor

What was the motivation for limiting the AllowTopLevelPaidExecutionFrom barrier, is there a security risk in having multiple assets in the holding register at the BuyExecution step?

@xlc
Copy link
Contributor

xlc commented Sep 19, 2023

To my understanding, it is indeed a security risk to allow unbounded asset withdrawal. But limit it to 1 is just too much, especially when the number is non configurable.

@bkchr
Copy link
Member

bkchr commented Oct 17, 2023

@franciscoaguirre @KiChjang please look into this ASAP.

bkchr pushed a commit that referenced this issue Oct 17, 2023
Partially addresses #1638

Still need a better solution to allow devs to have better control of
this.

---------

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
noandrea pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this issue Oct 18, 2023
Partially addresses paritytech#1638

Still need a better solution to allow devs to have better control of
this.

---------

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
tdimitrov pushed a commit that referenced this issue Oct 23, 2023
Partially addresses #1638

Still need a better solution to allow devs to have better control of
this.

---------

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
@Polkadot-Forum
Copy link

This issue has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v1-3-0/4614/1

@franciscoaguirre franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Mar 25, 2024
@acatangiu
Copy link
Contributor

This was fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known. T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Development

No branches or pull requests

7 participants