Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cumulus pov_recovery zombienet test is not failing when doing recovery with IfDisconnected::ImmediateError #1647

Closed
alindima opened this issue Sep 20, 2023 · 3 comments
Closed

Cumulus pov_recovery zombienet test is not failing when doing recovery with IfDisconnected::ImmediateError #1647

alindima opened this issue Sep 20, 2023 · 3 comments

Comments

@alindima
Copy link
Contributor

This is a regression test for attempting availability recovery if the subsystem is creating chunk requests with IfDisconnected::ImmediateError instead of TryConnect, but it doesn't fail on regression.

See: #1457 (comment)

The root cause is probably: paritytech/zombienet#1360
@alindima alindima mentioned this issue Sep 20, 2023
Merged
@pepoviola
Copy link
Contributor

Yes, that issue is root cause. I will create a new release of zombienet today with the fix (paritytech/zombienet#1361).
Thx!!

@pepoviola pepoviola mentioned this issue Sep 20, 2023
Merged
pepoviola added a commit that referenced this issue Sep 21, 2023
@pepoviola
bump zombienet version (#1655)
93bb492 
Includes:
- fix for paritytech/zombienet#1360 (root
cause of #1647)
- Improve default concurrency to spawn nodes.

Also, fix `var` name in CI file.

cc @skunert
@bkchr
Copy link
Member

bkchr commented Sep 25, 2023

@pepoviola was this fixed? If yes, please close the issue.

@pepoviola
Copy link
Contributor

Yes, closing now. Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pepoviola @bkchr @alindima