Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fungible/s decrease balance should respect preservation argument #1698

Closed
muharem opened this issue Sep 25, 2023 · 3 comments
Closed

fungible/s decrease balance should respect preservation argument #1698

muharem opened this issue Sep 25, 2023 · 3 comments
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@muharem
Copy link
Contributor

muharem commented Sep 25, 2023

At present default implementations of fungible/s and fungible impl by balances pallet do not respect preservation argument, and might reap the account even if preservation set to Preserve.

As result methods like transfer_and_hold, withdraw, settle also might reap the account regardless the argument.

All listed methods above should respect the preservation argument.
@muharem muharem added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Sep 25, 2023
@muharem
Copy link
Contributor Author

muharem commented Sep 25, 2023 •
edited
Loading

might be addressed here #1683 or here #1296

need this issue to reference in TODO here #1677

cc: @liamaharon

@muharem muharem mentioned this issue Sep 25, 2023
Closed
@liamaharon
Copy link
Contributor

@muharem happy to get it merged in your PR since mine is taking a long time to get a review

@muharem
Copy link
Contributor Author

muharem commented Jan 16, 2024

solved here - #1296

@muharem muharem closed this as completed Jan 16, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 26, 2024
@svyatonik
fix clippy (paritytech#1698)
5cce3e8
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 27, 2024
@svyatonik
fix clippy (paritytech#1698)
dc74c7e
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik
fix clippy (paritytech#1698)
fdda918
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
fix clippy (paritytech#1698)
0e21a47
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
fix clippy (paritytech#1698)
07f31ab
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
fix clippy (paritytech#1698)
b09a347
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
fix clippy (paritytech#1698)
378e13c
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
fix clippy (paritytech#1698)
bdb4889
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
fix clippy (paritytech#1698)
b6b1e3f
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
fix clippy (paritytech#1698)
9021365
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
fix clippy (paritytech#1698)
b9a6e53
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
fix clippy (paritytech#1698)
c6628c4
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
fix clippy (paritytech#1698)
dbc94f6
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @serban300
fix clippy (paritytech#1698)
342681b
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @serban300
fix clippy (paritytech#1698)
86c299a
bkchr pushed a commit that referenced this issue Apr 10, 2024
@svyatonik @bkchr
fix clippy (#1698)
66dfd2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fungible/s decrease balance preserves account paritytech/polkadot-sdk
2 participants
@muharem @liamaharon