Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update Rust nightly version for CI #2113

Closed
davxy opened this issue Nov 1, 2023 · 5 comments
Closed

[CI] Update Rust nightly version for CI #2113

davxy opened this issue Nov 1, 2023 · 5 comments
Assignees

Comments

@davxy
Copy link
Member

davxy commented Nov 1, 2023

CI pipeline job is failing because cargo nightly is not up to date.

$ cargo --version
cargo 1.73.0 (9c4383fb5 2023-08-26)
...
$ cargo +nightly --version
cargo 1.71.0-nightly (09276c703 2023-05-16)
@davxy
Copy link
Member Author

davxy commented Nov 1, 2023

cc @paritytech/ci

@davxy davxy changed the title Update Rust nightly version for CI [CI] Update Rust nightly version for CI Nov 1, 2023
@ggwpez
Copy link
Member

ggwpez commented Nov 1, 2023

Are you trying to use nightly features in Rust code? We do not use nightly for building, only formatting.

@davxy
Copy link
Member Author

davxy commented Nov 1, 2023

Not me. Is the CI that is trying to use nightly. https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4160212
It is using it to build a wasm artifact

[2023-11-01 11:45:55]   Executing build command: CARGO_TARGET_DIR="/builds/parity/mirrors/polkadot-sdk/target/debug/wbuild/node-template-runtime/target" RUSTFLAGS="-C target-cpu=mvp -C target-feature=-sign-ext -C link-arg=--export-table -Clink-arg=--export=__heap_base -C link-arg=--import-memory  " SKIP_WASM_BUILD="" "/usr/local/rustup/toolchains/nightly-2023-05-23-x86_64-unknown-linux-gnu/bin/cargo" "rustc" "--target=wasm32-unknown-unknown" "--manifest-path=/builds/parity/mirrors/polkadot-sdk/target/debug/wbuild/node-template-runtime/Cargo.toml" "--color=always" "--profile" "release"
[2023-11-01 11:45:55]   Using rustc version: rustc 1.71.0-nightly (8b4b20836 2023-05-22)

@davxy
Copy link
Member Author

davxy commented Nov 1, 2023

Are you trying to use nightly features in Rust code? We do not use nightly for building, only formatting.

Or maybe your question was if my code is using anything that is available on nightly only :-)
Sorry if I misunderstood.

My code is using a feature <integer>::div_ceil which is stable since 1.73

alvicsam added a commit that referenced this issue Nov 1, 2023
Run CI using new image with nightly 2023-11-01

cc #2113
cc paritytech/ci_cd#896
@davxy
Copy link
Member Author

davxy commented Nov 1, 2023

Closed by #2115

@davxy davxy closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants