-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have all the special storage keys in a single place #2126
Comments
The key format is also inconsistent. Some of them are We should also update the docs to include encoded hex and the expected value type. |
The Polkadot ones are not special keys, these are just the normal |
|
Ahh you got me :P
In a perfect way we would not need them at all. Or better abstracted. But we already have the |
I think we should use |
is this issue just all about creating a crate |
I am working on a feature of Chopsticks to decode all the storage keys. There are some keys requires special handling as they are not included in metadata.
Currently we have
polkadot-sdk/substrate/primitives/storage/src/lib.rs
Lines 192 to 216 in 86228fa
polkadot-sdk/substrate/frame/support/src/traits/metadata.rs
Lines 163 to 167 in 86228fa
polkadot-sdk/substrate/frame/support/src/storage/transactional.rs
Lines 34 to 37 in 86228fa
polkadot-sdk/substrate/primitives/consensus/grandpa/src/lib.rs
Lines 65 to 67 in 86228fa
polkadot-sdk/polkadot/primitives/src/v6/mod.rs
Lines 242 to 251 in 86228fa
Please let me know if I missed anything
This makes it really hard to implement a generic and all-catching storage decoder. Can we move all the Substrate well known keys to
sp_core::storage::well_known_keys
? The polkadot one are all in a single place so that's good.The text was updated successfully, but these errors were encountered: