Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFTs] create should emit CollectionMaxSupplySet when max_supply has value in config #2293

Closed
2 tasks done
vikiival opened this issue Nov 13, 2023 · 1 comment · Fixed by #2626
Closed
2 tasks done

[NFTs] create should emit CollectionMaxSupplySet when max_supply has value in config #2293

vikiival opened this issue Nov 13, 2023 · 1 comment · Fixed by #2626
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.

Comments

@vikiival
Copy link
Contributor

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

Context

When someone creates an collection with config.max_supply = 1.
The chain should emit CollectionMaxSupplySet same as this function set_collection_max_supply

polkadot-sdk/substrate/frame/nfts/src/lib.rs

Line 1656 in 604704a

/// Emits `CollectionMaxSupplySet` event when successful.

polkadot-sdk/substrate/frame/nfts/src/features/create_delete_collection.rs

Line 67 in 5f4ce80

CollectionConfigOf::<T, I>::insert(&collection, config);

Expected

I expect that CollectionMaxSupplySet should be emitted then config.max_supply has a value.

Steps to reproduce
@vikiival vikiival added I10-unconfirmed Issue might be valid, but it's not yet known. I2-bug The node fails to follow expected behavior. labels Nov 13, 2023
@vikiival vikiival mentioned this issue Nov 13, 2023
Closed
@bkchr
Copy link
Member

bkchr commented Nov 21, 2023

CC @jsidorenko

@vikiival vikiival mentioned this issue Dec 4, 2023
Closed
1 task
@jsidorenko jsidorenko mentioned this issue Dec 5, 2023
Merged
jsidorenko added a commit that referenced this issue Dec 8, 2023
@jsidorenko
[NTFs] Emit CollectionMaxSupplySet on collection create (#2626)
1bdfb29 
Closes #2293 

if the max_supply is set during the collection creation, we emit the
`CollectionMaxSupplySet` event
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this issue Mar 25, 2024
@jsidorenko
[NTFs] Emit CollectionMaxSupplySet on collection create (paritytech#2626
4c37f8e 
)

Closes paritytech#2293 

if the max_supply is set during the collection creation, we emit the
`CollectionMaxSupplySet` event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[NTFs] Emit CollectionMaxSupplySet on collection create paritytech/polkadot-sdk
2 participants
@bkchr @vikiival