Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce log output of beefy pallet (>100k chars) #3407

Closed
2 tasks done
ScepticMatt opened this issue Feb 20, 2024 · 1 comment · Fixed by #3418
Closed
2 tasks done

Reduce log output of beefy pallet (>100k chars) #3407

ScepticMatt opened this issue Feb 20, 2024 · 1 comment · Fixed by #3418
Assignees
@acatangiu
Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue.

Comments

@ScepticMatt
Copy link

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Motivation

Beefy (on Kusama 1.7.1) causes a huge amount of log output by printing a large list of addresses.

Request

Stop printing full list of addresses (see attachments)
Loading BEEFY .txt
Round 21959912 concluded final.txt

Solution

Print statistics about BEEFY instead of the full list

Are you willing to help with this request?

Yes!
@ScepticMatt ScepticMatt added the I5-enhancement An additional feature request. label Feb 20, 2024
@github-actions github-actions bot added the I10-unconfirmed Issue might be valid, but it's not yet known. label Feb 20, 2024
@acatangiu acatangiu added I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. and removed I5-enhancement An additional feature request. I10-unconfirmed Issue might be valid, but it's not yet known. labels Feb 20, 2024
@bkchr
Copy link
Member

bkchr commented Feb 21, 2024

None of these messages should be printed by info logs. They have exactly 0 value for an operator. They can be degraded to debug messages.

@acatangiu acatangiu mentioned this issue Feb 21, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 21, 2024
@acatangiu
sc-consensus-beefy: reduce log levels (#3418)
cbeccad 
fixes #3407
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this issue Mar 25, 2024
@acatangiu
sc-consensus-beefy: reduce log levels (paritytech#3418)
af5ed52 
fixes paritytech#3407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acatangiu acatangiu

Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sc-consensus-beefy: reduce log levels acatangiu/polkadot-sdk
4 participants
@bkchr @ScepticMatt @serban300 @acatangiu