-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate the update logic for MinNominatorBond
and MinValidatorBond
#425
Labels
I5-enhancement
An additional feature request.
Comments
Am taking it @kianenigma |
the-right-joyce
added
I5-enhancement
An additional feature request.
and removed
C3-medium
labels
Aug 25, 2023
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 8, 2024
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 8, 2024
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 9, 2024
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 9, 2024
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 9, 2024
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 9, 2024
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 9, 2024
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 9, 2024
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 10, 2024
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 10, 2024
jonathanudd
pushed a commit
to jonathanudd/polkadot-sdk
that referenced
this issue
Apr 10, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Kinda similar to the work done in https://github.com/paritytech/substrate/pull/12970/files#, we want to be able to have possibly automatic logic updating these values. A default implementation could still easily set them to value stored onchain.
Multiple implementation options exist (taking the example of updating
MinNominatorBond
only):Custom for staking. Similar to how [NPoS] Implements dynamic number of nominators substrate#12970 introduced a new
trait NominationQuota
, we also add new custom traits, bake the logic deep into the staking pallet. Staking will decide when and how to update this. A configuration item will just decide which update mode is being used.Use a
type Convert<InputBalance, OutputBalance>
to receive the new value.InputBalance
would be theMinActiveStake
added in storemin-active-bond
onchain substrate#12746, output would be the newMinNominatorBond
.Use a slightly more generic
type Get<Balance>
. called per era, it should return the newMinNominatorBond
.Probably more ways to do this.
Inspired by the comment in https://polkadot.polkassembly.io/post/1650
The text was updated successfully, but these errors were encountered: