Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate the update logic for MinNominatorBond and MinValidatorBond #425

Open
kianenigma opened this issue Mar 6, 2023 · 1 comment
Open
Labels
I5-enhancement An additional feature request.

Comments

@kianenigma
Copy link
Contributor

Kinda similar to the work done in https://github.com/paritytech/substrate/pull/12970/files#, we want to be able to have possibly automatic logic updating these values. A default implementation could still easily set them to value stored onchain.

Multiple implementation options exist (taking the example of updating MinNominatorBond only):

  1. Custom for staking. Similar to how [NPoS] Implements dynamic number of nominators substrate#12970 introduced a new trait NominationQuota, we also add new custom traits, bake the logic deep into the staking pallet. Staking will decide when and how to update this. A configuration item will just decide which update mode is being used.

  2. Use a type Convert<InputBalance, OutputBalance> to receive the new value. InputBalance would be the MinActiveStake added in store min-active-bond onchain substrate#12746, output would be the new MinNominatorBond.

  3. Use a slightly more generic type Get<Balance>. called per era, it should return the new MinNominatorBond.

Probably more ways to do this.

Inspired by the comment in https://polkadot.polkassembly.io/post/1650

@MrishoLukamba
Copy link

Am taking it @kianenigma

@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I5-enhancement An additional feature request. and removed C3-medium labels Aug 25, 2023
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
jonathanudd pushed a commit to jonathanudd/polkadot-sdk that referenced this issue Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I5-enhancement An additional feature request.
Projects
Status: 📕 Backlog
Development

No branches or pull requests

3 participants