Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elastic scaling: introduce new CandidateDescriptor and related primitives #5044

Closed
sandreim opened this issue Jul 17, 2024 · 0 comments · Fixed by #5322
Closed

Elastic scaling: introduce new CandidateDescriptor and related primitives #5044

sandreim opened this issue Jul 17, 2024 · 0 comments · Fixed by #5322
Assignees
@sandreim

Comments

@sandreim
Copy link
Contributor

sandreim commented Jul 17, 2024 •
edited
Loading

Implement the primitives as described in RFC #103 . We should introduce the new ones as staging

Polkadot:

  • CandidateDescriptor
  • CandidateReceipt
  • CommittedCandidateReceipt
  • BackedCandidate
  • UMPMessage / UMPSignal

The implementation should hide the versioning and backwards compatibility of new/old versions making it easy for higher level code to not rely on any versioning. It should also check validity of the core index information.
@sandreim sandreim converted this from a draft issue Jul 17, 2024
@sandreim sandreim mentioned this issue Aug 12, 2024
Merged
3 tasks
@sandreim sandreim moved this from Backlog to Review in progress in parachains team board Aug 13, 2024
@sandreim sandreim self-assigned this Aug 20, 2024
github-merge-queue bot pushed a commit that referenced this issue Sep 2, 2024
@sandreim
Elastic scaling: introduce new candidate receipt primitive (#5322)
ad2ac0d 
closes #5044

This PR switches the runtime to the new receipts format (vstaging
primitives). I've implemented `From` to convert from new primitives to
`v7` primitives and used them in the node runtime api client
implementation. Until we implement the support in the node, it will
continue e to use the v7 primitives but the runtime apis already use the
new primitives.


An expected downside of RFC103 is decoding V2 receipts shows garbage
values if the input is V1:

_![ima_9ce77de](https://github.com/user-attachments/assets/71d80e78-e238-4518-8cd1-548ae0d74b70)_

TODO:
- [x] fix tests
- [x] A few more tests for the new primitives
- [x] PRDoc

---------

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@github-project-automation github-project-automation bot moved this from Review in progress to Completed in parachains team board Sep 2, 2024
x3c41a pushed a commit that referenced this issue Sep 4, 2024
@sandreim @x3c41a
Elastic scaling: introduce new candidate receipt primitive (#5322)
153d03a 
closes #5044

This PR switches the runtime to the new receipts format (vstaging
primitives). I've implemented `From` to convert from new primitives to
`v7` primitives and used them in the node runtime api client
implementation. Until we implement the support in the node, it will
continue e to use the v7 primitives but the runtime apis already use the
new primitives.

An expected downside of RFC103 is decoding V2 receipts shows garbage
values if the input is V1:

_![ima_9ce77de](https://github.com/user-attachments/assets/71d80e78-e238-4518-8cd1-548ae0d74b70)_

TODO:
- [x] fix tests
- [x] A few more tests for the new primitives
- [x] PRDoc

---------

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandreim sandreim

Labels
None yet
Projects
parachains team board
Status: Pending Audit
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Elastic scaling: introduce new candidate receipt primitive paritytech/polkadot-sdk
1 participant
@sandreim