Return peer info instead of Peerset::debug_info
#507
Labels
I3-annoyance
The node behaves within expectations, however this “expected behaviour” itself is at issue.
Comments
the-right-joyce
added
I3-annoyance
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 8, 2024
* Bump futures from 0.3.7 to 0.3.8 Bumps [futures](https://github.com/rust-lang/futures-rs) from 0.3.7 to 0.3.8. - [Release notes](https://github.com/rust-lang/futures-rs/releases) - [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md) - [Commits](rust-lang/futures-rs@0.3.7...0.3.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Fix clippy. * Fix more clippy. * Fix clippy again? * Cliipy yet again. Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 8, 2024
* Bump futures from 0.3.7 to 0.3.8 Bumps [futures](https://github.com/rust-lang/futures-rs) from 0.3.7 to 0.3.8. - [Release notes](https://github.com/rust-lang/futures-rs/releases) - [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md) - [Commits](rust-lang/futures-rs@0.3.7...0.3.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Fix clippy. * Fix more clippy. * Fix clippy again? * Cliipy yet again. Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 8, 2024
* Bump futures from 0.3.7 to 0.3.8 Bumps [futures](https://github.com/rust-lang/futures-rs) from 0.3.7 to 0.3.8. - [Release notes](https://github.com/rust-lang/futures-rs/releases) - [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md) - [Commits](rust-lang/futures-rs@0.3.7...0.3.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Fix clippy. * Fix more clippy. * Fix clippy again? * Cliipy yet again. Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 8, 2024
* Bump futures from 0.3.7 to 0.3.8 Bumps [futures](https://github.com/rust-lang/futures-rs) from 0.3.7 to 0.3.8. - [Release notes](https://github.com/rust-lang/futures-rs/releases) - [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md) - [Commits](rust-lang/futures-rs@0.3.7...0.3.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Fix clippy. * Fix more clippy. * Fix clippy again? * Cliipy yet again. Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 9, 2024
* Bump futures from 0.3.7 to 0.3.8 Bumps [futures](https://github.com/rust-lang/futures-rs) from 0.3.7 to 0.3.8. - [Release notes](https://github.com/rust-lang/futures-rs/releases) - [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md) - [Commits](rust-lang/futures-rs@0.3.7...0.3.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Fix clippy. * Fix more clippy. * Fix clippy again? * Cliipy yet again. Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 9, 2024
* Bump futures from 0.3.7 to 0.3.8 Bumps [futures](https://github.com/rust-lang/futures-rs) from 0.3.7 to 0.3.8. - [Release notes](https://github.com/rust-lang/futures-rs/releases) - [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md) - [Commits](rust-lang/futures-rs@0.3.7...0.3.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Fix clippy. * Fix more clippy. * Fix clippy again? * Cliipy yet again. Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 9, 2024
* Bump futures from 0.3.7 to 0.3.8 Bumps [futures](https://github.com/rust-lang/futures-rs) from 0.3.7 to 0.3.8. - [Release notes](https://github.com/rust-lang/futures-rs/releases) - [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md) - [Commits](rust-lang/futures-rs@0.3.7...0.3.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Fix clippy. * Fix more clippy. * Fix clippy again? * Cliipy yet again. Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 9, 2024
* Bump futures from 0.3.7 to 0.3.8 Bumps [futures](https://github.com/rust-lang/futures-rs) from 0.3.7 to 0.3.8. - [Release notes](https://github.com/rust-lang/futures-rs/releases) - [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md) - [Commits](rust-lang/futures-rs@0.3.7...0.3.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Fix clippy. * Fix more clippy. * Fix clippy again? * Cliipy yet again. Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 9, 2024
* Bump futures from 0.3.7 to 0.3.8 Bumps [futures](https://github.com/rust-lang/futures-rs) from 0.3.7 to 0.3.8. - [Release notes](https://github.com/rust-lang/futures-rs/releases) - [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md) - [Commits](rust-lang/futures-rs@0.3.7...0.3.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Fix clippy. * Fix more clippy. * Fix clippy again? * Cliipy yet again. Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 9, 2024
* Bump futures from 0.3.7 to 0.3.8 Bumps [futures](https://github.com/rust-lang/futures-rs) from 0.3.7 to 0.3.8. - [Release notes](https://github.com/rust-lang/futures-rs/releases) - [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md) - [Commits](rust-lang/futures-rs@0.3.7...0.3.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Fix clippy. * Fix more clippy. * Fix clippy again? * Cliipy yet again. Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 10, 2024
* Bump futures from 0.3.7 to 0.3.8 Bumps [futures](https://github.com/rust-lang/futures-rs) from 0.3.7 to 0.3.8. - [Release notes](https://github.com/rust-lang/futures-rs/releases) - [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md) - [Commits](rust-lang/futures-rs@0.3.7...0.3.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Fix clippy. * Fix more clippy. * Fix clippy again? * Cliipy yet again. Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 10, 2024
* Bump futures from 0.3.7 to 0.3.8 Bumps [futures](https://github.com/rust-lang/futures-rs) from 0.3.7 to 0.3.8. - [Release notes](https://github.com/rust-lang/futures-rs/releases) - [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md) - [Commits](rust-lang/futures-rs@0.3.7...0.3.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Fix clippy. * Fix more clippy. * Fix clippy again? * Cliipy yet again. Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
bkchr
pushed a commit
that referenced
this issue
Apr 10, 2024
* Bump futures from 0.3.7 to 0.3.8 Bumps [futures](https://github.com/rust-lang/futures-rs) from 0.3.7 to 0.3.8. - [Release notes](https://github.com/rust-lang/futures-rs/releases) - [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md) - [Commits](rust-lang/futures-rs@0.3.7...0.3.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Fix clippy. * Fix more clippy. * Fix clippy again? * Cliipy yet again. Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a follow-up issue to paritytech/substrate#13611.
Originally,
Peersethad centralized information on peer states, and this info was returned inPeerset::debug_info. This information was served as part ofsystem_unstable_networkStateRPC request.Once paritytech/substrate#13611 is merged, the peer states are moved to
ProtocolControllerinstances, withPeerStorekeeping the peer reputations.This issue is to research if any valuable information can be returned from
PeerStoreorProtocolControllerinstead ofPeerset::debug_info, or whether we should remove this call completely.The text was updated successfully, but these errors were encountered: