Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notifications_back_pressure test is flaky #537

Open
pepyakin opened this issue Jun 8, 2021 · 2 comments
Open

notifications_back_pressure test is flaky #537

pepyakin opened this issue Jun 8, 2021 · 2 comments
Assignees
@tomaka
Labels
I2-bug The node fails to follow expected behavior.

Comments

@pepyakin
Copy link
Contributor

pepyakin commented Jun 8, 2021

During working on paritytech/substrate#8998 I've observed a test failure of notifications_back_pressure from sc-network. Gitlab logs. This failure doesn't seem to be related to anything I was working with so this test seem to be flaky.
@tomaka tomaka added the I3-bug label Jun 8, 2021
@kpp
Copy link

kpp commented Jun 16, 2021

I ran the test 100 times, none of them failed...

@kpp kpp mentioned this issue Nov 8, 2021
Closed
@nazar-pc
Copy link
Contributor

I had it failing on me once today:

---- service::tests::notifications_back_pressure stdout ----
thread 'service::tests::notifications_back_pressure' panicked at 'called `Result::unwrap()` on an `Err` value: Closed', client/network/src/service/tests.rs:461:84

Which is this line: https://github.com/paritytech/substrate/blob/97a2bf9b26357cbefa56cabbd1c4579240e170ff/client/network/src/service/tests.rs#L461

Tried to reproduce and wasn't able to (tried with high CPU load and idle system).

@ggwpez ggwpez mentioned this issue Aug 24, 2023
Open
16 tasks
@altonen altonen transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I2-bug The node fails to follow expected behavior. and removed I3-bug labels Aug 25, 2023
claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
@vgeddes
Update dependencies for serde, codec (paritytech#537)
a6540bd
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 26, 2024
@svyatonik
Fixed clippy warnings (paritytech#537)
1eedbb1 
* fixed clippy warnings

* Revert "Actually use pinned nightly version when building runtimes (paritytech#465)"

This reverts commit 03ef763.

* Revert "Pin Rust Nightly Version (paritytech#420)"

This reverts commit 8902ac2.

* fix after revert

* another fix after revert

* more clippy fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 27, 2024
@svyatonik
Fixed clippy warnings (paritytech#537)
5e4637c 
* fixed clippy warnings

* Revert "Actually use pinned nightly version when building runtimes (paritytech#465)"

This reverts commit 8343bcb.

* Revert "Pin Rust Nightly Version (paritytech#420)"

This reverts commit 8902ac2.

* fix after revert

* another fix after revert

* more clippy fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik
Fixed clippy warnings (paritytech#537)
1b18c63 
* fixed clippy warnings

* Revert "Actually use pinned nightly version when building runtimes (paritytech#465)"

This reverts commit dedddb6.

* Revert "Pin Rust Nightly Version (paritytech#420)"

This reverts commit 8902ac2.

* fix after revert

* another fix after revert

* more clippy fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
Fixed clippy warnings (paritytech#537)
a524276 
* fixed clippy warnings

* Revert "Actually use pinned nightly version when building runtimes (paritytech#465)"

This reverts commit dedddb6.

* Revert "Pin Rust Nightly Version (paritytech#420)"

This reverts commit 8902ac2.

* fix after revert

* another fix after revert

* more clippy fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
Fixed clippy warnings (paritytech#537)
e3aa51f 
* fixed clippy warnings

* Revert "Actually use pinned nightly version when building runtimes (paritytech#465)"

This reverts commit dedddb6.

* Revert "Pin Rust Nightly Version (paritytech#420)"

This reverts commit 8902ac2.

* fix after revert

* another fix after revert

* more clippy fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
Fixed clippy warnings (paritytech#537)
baf6288 
* fixed clippy warnings

* Revert "Actually use pinned nightly version when building runtimes (paritytech#465)"

This reverts commit dedddb6.

* Revert "Pin Rust Nightly Version (paritytech#420)"

This reverts commit 8902ac2.

* fix after revert

* another fix after revert

* more clippy fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
Fixed clippy warnings (paritytech#537)
3e03e03 
* fixed clippy warnings

* Revert "Actually use pinned nightly version when building runtimes (paritytech#465)"

This reverts commit dedddb6.

* Revert "Pin Rust Nightly Version (paritytech#420)"

This reverts commit 8902ac2.

* fix after revert

* another fix after revert

* more clippy fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Fixed clippy warnings (paritytech#537)
e2f7333 
* fixed clippy warnings

* Revert "Actually use pinned nightly version when building runtimes (paritytech#465)"

This reverts commit dedddb6.

* Revert "Pin Rust Nightly Version (paritytech#420)"

This reverts commit 8902ac2.

* fix after revert

* another fix after revert

* more clippy fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Fixed clippy warnings (paritytech#537)
de111e0 
* fixed clippy warnings

* Revert "Actually use pinned nightly version when building runtimes (paritytech#465)"

This reverts commit dedddb6.

* Revert "Pin Rust Nightly Version (paritytech#420)"

This reverts commit 8902ac2.

* fix after revert

* another fix after revert

* more clippy fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Fixed clippy warnings (paritytech#537)
679a94f 
* fixed clippy warnings

* Revert "Actually use pinned nightly version when building runtimes (paritytech#465)"

This reverts commit dedddb6.

* Revert "Pin Rust Nightly Version (paritytech#420)"

This reverts commit 8902ac2.

* fix after revert

* another fix after revert

* more clippy fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Fixed clippy warnings (paritytech#537)
e4ae3c6 
* fixed clippy warnings

* Revert "Actually use pinned nightly version when building runtimes (paritytech#465)"

This reverts commit dedddb6.

* Revert "Pin Rust Nightly Version (paritytech#420)"

This reverts commit 8902ac2.

* fix after revert

* another fix after revert

* more clippy fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Fixed clippy warnings (paritytech#537)
5564398 
* fixed clippy warnings

* Revert "Actually use pinned nightly version when building runtimes (paritytech#465)"

This reverts commit dedddb6.

* Revert "Pin Rust Nightly Version (paritytech#420)"

This reverts commit 8902ac2.

* fix after revert

* another fix after revert

* more clippy fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Fixed clippy warnings (paritytech#537)
a58259f 
* fixed clippy warnings

* Revert "Actually use pinned nightly version when building runtimes (paritytech#465)"

This reverts commit dedddb6.

* Revert "Pin Rust Nightly Version (paritytech#420)"

This reverts commit 8902ac2.

* fix after revert

* another fix after revert

* more clippy fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @serban300
Fixed clippy warnings (paritytech#537)
bdd1f0b 
* fixed clippy warnings

* Revert "Actually use pinned nightly version when building runtimes (paritytech#465)"

This reverts commit dedddb6.

* Revert "Pin Rust Nightly Version (paritytech#420)"

This reverts commit 8902ac2.

* fix after revert

* another fix after revert

* more clippy fixes
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @serban300
Fixed clippy warnings (paritytech#537)
f5162e6 
* fixed clippy warnings

* Revert "Actually use pinned nightly version when building runtimes (paritytech#465)"

This reverts commit dedddb6.

* Revert "Pin Rust Nightly Version (paritytech#420)"

This reverts commit 8902ac2.

* fix after revert

* another fix after revert

* more clippy fixes
bkchr pushed a commit that referenced this issue Apr 10, 2024
@svyatonik @bkchr
Fixed clippy warnings (#537)
c20b4c8 
* fixed clippy warnings

* Revert "Actually use pinned nightly version when building runtimes (#465)"

This reverts commit dedddb6.

* Revert "Pin Rust Nightly Version (#420)"

This reverts commit 8902ac2.

* fix after revert

* another fix after revert

* more clippy fixes
This was referenced Jun 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomaka tomaka

Labels
I2-bug The node fails to follow expected behavior.
Projects
Networking
Status: Backlog 🗒
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kpp @nazar-pc @tomaka @pepyakin @altonen @the-right-joyce