-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend network protocol with justification announcements #571
Comments
The key-thing here is making sure that justification announcements propagate, so if I import a valid justification I also reannounce it to my peers. Probably the hardest thing is not announcing too many justifications and not reannouncing any justifications that are lower than our most recent finalized block. |
Is the issue still relevant? Why do we want to announce justifications? To have them available quicker?
This is done. |
It isn't strictly necessary anymore, full clients can just rely on the GRANDPA commits to stay up-to-date to finality. This is what we are doing with the observer already. It's probably mainly useful for the light client, so that it can track finality in between validator set changes (validator set change blocks are the only ones required to be to be finalized and that the light client will fetch justifications for). Either way it's not something I see us implementing soon, so if we want to keep the issue let's push to a later milestone. I'll also unassign myself in case someone else wants to take it. |
Refactor solution verification to move KZG into separate parameter
…llo (paritytech#571) Bumps [simple-get](https://github.com/feross/simple-get) from 2.8.1 to 2.8.2. - [Release notes](https://github.com/feross/simple-get/releases) - [Commits](feross/simple-get@v2.8.1...v2.8.2) --- updated-dependencies: - dependency-name: simple-get dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Just as new blocks are announced and gossiped on the network, new justifications (if produced behind the head) should be as well.
The sync protocol needs to be provided with an object that knows how to check + import justifications (this could go on the
BlockImport
trait)Altering the finality notification stream slightly should make issuing such broadcasts easy to do.
The text was updated successfully, but these errors were encountered: