Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ttl and max_availability_timeouts from the HostConfiguration #6067

Open
alindima opened this issue Oct 15, 2024 · 2 comments
Open

Remove ttl and max_availability_timeouts from the HostConfiguration #6067

alindima opened this issue Oct 15, 2024 · 2 comments
Assignees
@alindima
Labels
T4-runtime_API This PR/Issue is related to runtime APIs. T8-polkadot This PR/Issue is related to/affects the Polkadot network.

Comments

@alindima
Copy link
Contributor

Needs to be a follow-up of #5461.

Blocked by: #64 . Adding the version check workaround in every place where we use the HostConfiguration in a runtime API is not feasible. We need to wait for the proper fix.
@alindima alindima added T4-runtime_API This PR/Issue is related to runtime APIs. T8-polkadot This PR/Issue is related to/affects the Polkadot network. labels Oct 15, 2024
@alindima
Copy link
Contributor Author

Code was already written here: d31e0a0 but reverted. Just need to copy-paste (and adapt) this commit at the right time

@alindima alindima self-assigned this Oct 15, 2024
@burdges
Copy link

burdges commented Oct 15, 2024 •
edited
Loading

What did max_availability_timeouts do?. Got it. Yeah why not.

@alindima alindima mentioned this issue Oct 16, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Oct 21, 2024
@alindima @sandreim
runtime: remove ttl (#5461)
ee803b7 
Resolves #4776

This will enable proper core-sharing between paras, even if one of them
is not producing blocks.

TODO:
- [x] duplicate first entry in the claim queue if the queue used to be
empty
- [x] don't back anything if at the end of the block there'll be a
session change
- [x] write migration for removing the availability core storage
- [x] update and write unit tests
- [x] prdoc
- [x] add zombienet test for synchronous backing
- [x] add zombienet test for core-sharing paras where one of them is not
producing any blocks

_Important note:_
The `ttl` and `max_availability_timeouts` fields of the
HostConfiguration are not removed in this PR, due to #64.
Adding the workaround with the storage version check for every use of
the active HostConfiguration in all runtime APIs would be insane, as
it's used in almost all runtime APIs.

So even though the ttl and max_availability_timeouts fields will now be
unused, they will remain part of the host configuration.

These will be removed in a separate PR once #64 is fixed. Tracked by
#6067

---------

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Co-authored-by: Andrei Sandu <andrei-mihail@parity.io>
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
Co-authored-by: command-bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alindima alindima

Labels
T4-runtime_API This PR/Issue is related to runtime APIs. T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
parachains team board
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@burdges @alindima