Fix check_bootnodes job to only fail on some percentage #647
Assignees
Labels
I3-annoyance
The node behaves within expectations, however this “expected behaviour” itself is at issue.
Comments
|
The cherry on top would be a second percentage, lower, say 5%, and if we remains under this amount of failures, you create a PR to remove the affected bootnodes. It may also be useful for this worfklow to automatic retry a few times on failure to cope for intermitent failures. |
|
What is then the purpose of this check, if we already start allowing bootnodes to fail. |
the-right-joyce
added
I3-annoyance
claravanstaden
pushed a commit
to Snowfork/polkadot-sdk
that referenced
this issue
Dec 8, 2023
…h#637) * WIP: attempt at new data structures * Specify path to config trait * Check AccountId's traits for EnqueuedMessage * Reorder MessageBundle type params * Add trait bounds to AccountId * Don't store AccountId in MessageBundle messages The AccountId is already in the MessageBundle, so no need to add it to every message. * Ensure that AccountId implements MaxEncodedLen * Finish rename to Nonces * Whitespace * Remove use of principal * Fix struct access in average_payload_size * WIP Collect MessageBundles partitioned by AccountId * Convert message queue to map of message bundles * Fix account id used for nonces in test * Fix warnings * Convert message bundles to Vec * Remove last uses of principal in basic channel * Found a better way to handle this Just use BoundedVec * Insert spaces to help with Markdown folding * Fix BTreeMap import * Revert "Remove last uses of principal in basic channel" This reverts commit 2f5d6e07a56bf74baeaf6f0421b68beb77b17644. * Fix some benchmarking types * Remove last uses of principal in basic channel Leave the set_principal call in place as a no-op to avoid removing the config for Call. We'll re-add it when we add the leaf node proof anyway. * First stab at Merklizing all message bundles I mean, if it compiles... 🤷 * Make keccak256 public to try resolve import issues * Use configured Hash type * rustfmt * Fix tests in merkle_proof * Fix nonce update * Remove not_authorized test * Add TODO * Ignore large tests * rustfmt * Store all message bundles in the event * Clean up commit() a bit * Extract function make_message_bundles * Eth-encode message bundles before merklizing them * Update comments * Remove unused function * Persist ABI-encoded message bundles * Use SCALE encoding for off-chain message bundles * Fix debug import * Switch to Token::FixedBytes * s/map/for/ * Remove loop implementation * Remove generic output type * rustfmt * Add StoredLeaves struct to communicate intent * WIP Custom RPC and runtime API * fixes (paritytech#647) * Update snow{blink,bridge} with fixes * Move merkle_proof to a separate crate * Add RPC call stub * Add runtime API implementation * Remove basic channel's RPC runtime API * WIP SCALE-encode Merkle proof from RPC call * Move StoredLeaves struct into primitives crate * Disable default features in basic channel crates * Add import for function * Use u64 instead of usize for proofs * Fix missed issues from removing the runtime API * Fix merkle-proof tests * Update basic outbound channel's tests for commit() * rustfmt * Clean up RPC call * Fix typo & remove unused import & comment * Replace encode with as_ref for ethabi encoding * Remove AsRef implementation for MessageBundle * Fix up RPC crate * Remove unused dependencies in basic channel * Remove redundant package names * Use import alias * Reorder rpc pallet * rustfmt * Mention outbound in Merkle proof RPC * Remove unused error * Remove set_principal from basic outbound channel * Update docstring for commit() * Ignore unused result * Shorten type * Remove unused dependency * Add prefix to incentivized channel in runtimes * Remove unused import * Remove primitives crate * Add V2 of basic inbound channel * Fix typos * Re-order message types * Fix use of nonces * Generate commitment from message bundle & proof * Fix contract name * Generate basic inbound channel v2 go bindings * Fix RPC name * Fix rpc handler (paritytech#659) * Detect leaf index out of bounds in RPC * Add tests for RPC handler * Overwrite BasicInboundChannel instead of using V2 * Link MerkleProof library for testing * Typos * Add account id filter to parachain relayer * Add MerkleProof library to channel deployment * Add MerkleProof RPC to parachain relayer * Extract account id decoding to getter * Simplify search for matching bundle * Forward Merkle proof to inbound channel contract * Fix mapstructure tag * Move decoded account id to listener struct * Tweak error messages * Extract finding bundle * Extract fetchBundleProof * Use existing parachain connection * Fix account id decoding * Fetch basic channel nonce by accountID * Reuse accountID stored on startup * Fix listener decoding & writer bounds check * Add account id to message bundle log * Remove TODO This is only relevant if we expect to have around 2**63 different accounts with messages in the same commitment. * Add RPC name to error messages * Use the Alice account id as default for ACCOUNT_ID * Mention build-essential for setting up lodestar * Fix log file names * Log leafProof and hashSides in relayer * Fix hash side value Should be hashed on the left when the side is true, which is when the index is even. * Use same names and param order as contract * Update contract fixture data * Revert "Fix hash side value" This reverts commit ec0b2e9aa7ee2a8605f68152392983e344f0057f. * Add reminder to use a port of a relay chain node * Fix basic inbound channel contract tests * Mention port forwarding in port reminder * Replace pointer with byte array * Improve error logs * Return proof value instead of mutating pointer * Add second message bundle to basic channel test * WIP Add second account to basic channel e2e test * Start accountID with lowercase * Update new dependencies to 0.9.25 * Fix RPC handler tests * Update parachain metadata * Allow multiple accountIDs in parachain relayer * Fix scanning logic * Update basic nonces log * Fix initial len of nonces slice * Fix jq for multiple account ids * Add bob key for E2E test * Check correct colletion's length to stop scanning * Fix param description * Whitespace * Ignore local asdf versions * Replace base 2 log with simpler bit calculation * Remove resolved TODOs * Typo * Add comment explaining ACCOUNT_IDS * s/accountIDs/accounts/g * Add issue key to TODO * Typo * Add geth version to README * Fix templating * Update parachain lockfile * Fix recipient address * Fix dotapp tests after rename Co-authored-by: Vincent Geddes <vincent.geddes@hey.com> Co-authored-by: Vincent Geddes <vincent@snowfork.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the check_bootnodes action will fail if any of the bootnodes for a given network aren't contactable. Alter the job so that it will only fail if some percentage (let's start with 20%) of bootnodes don't allow us to find peers. Also include the amount & percentage in the job output at the end.
The text was updated successfully, but these errors were encountered: