Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SystemClock is duplicated on a lot of places in the project #781

Open
tdimitrov opened this issue Sep 1, 2022 · 0 comments
Open

SystemClock is duplicated on a lot of places in the project #781

tdimitrov opened this issue Sep 1, 2022 · 0 comments
Assignees
@tdimitrov
Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue.

Comments

@tdimitrov
Copy link
Contributor

E.g. here: https://github.com/paritytech/polkadot/blob/566a403be1277612f413136d9febe5efaabcf417/node/core/dispute-coordinator/src/status.rs#L142

Extract the implementation in node-primitives or subsystem-util and remove the duplications.

Follow up from paritytech/polkadot#5567 (comment)
@tdimitrov tdimitrov self-assigned this Sep 1, 2022
@tdimitrov tdimitrov mentioned this issue Sep 1, 2022
Merged
5 tasks
@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
@the-right-joyce the-right-joyce added I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. T9-parachains_protocol and removed I4-annoyance labels Aug 25, 2023
claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
@vgeddes @doubledup @alistair-singh
Contracts for XCMv3 (paritytech#781)
4f5bfd6 
Co-authored-by: David Dunn <26876072+doubledup@users.noreply.github.com>
Co-authored-by: Alistair Singh <alistair.singh7@gmail.com>
@tdimitrov tdimitrov moved this to Backlog in parachains team board Jan 29, 2024
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
@dependabot
Bump lru from 0.7.7 to 0.7.8 (paritytech#781)
93c57cf 
Bumps [lru](https://github.com/jeromefroe/lru-rs) from 0.7.7 to 0.7.8.
- [Release notes](https://github.com/jeromefroe/lru-rs/releases)
- [Changelog](https://github.com/jeromefroe/lru-rs/blob/master/CHANGELOG.md)
- [Commits](jeromefroe/lru-rs@0.7.7...0.7.8)

---
updated-dependencies:
- dependency-name: lru
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@tomusdrw @HCastano @serban300
Derive bridged accounts (paritytech#781)
d32a737 
* Add derivation support.

* Add custom decoder for Accounts.

* cargo fmt --all

* Fix warn.

* Fix articles.

Co-authored-by: Hernando Castano <castano.ha@gmail.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@tomusdrw @HCastano @serban300
Derive bridged accounts (paritytech#781)
59f331d 
* Add derivation support.

* Add custom decoder for Accounts.

* cargo fmt --all

* Fix warn.

* Fix articles.

Co-authored-by: Hernando Castano <castano.ha@gmail.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@tomusdrw @HCastano @serban300
Derive bridged accounts (paritytech#781)
6c001a7 
* Add derivation support.

* Add custom decoder for Accounts.

* cargo fmt --all

* Fix warn.

* Fix articles.

Co-authored-by: Hernando Castano <castano.ha@gmail.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@tomusdrw @HCastano @serban300
Derive bridged accounts (paritytech#781)
de926b0 
* Add derivation support.

* Add custom decoder for Accounts.

* cargo fmt --all

* Fix warn.

* Fix articles.

Co-authored-by: Hernando Castano <castano.ha@gmail.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @HCastano @serban300
Derive bridged accounts (paritytech#781)
d2f426b 
* Add derivation support.

* Add custom decoder for Accounts.

* cargo fmt --all

* Fix warn.

* Fix articles.

Co-authored-by: Hernando Castano <castano.ha@gmail.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @HCastano @serban300
Derive bridged accounts (paritytech#781)
6ef60ce 
* Add derivation support.

* Add custom decoder for Accounts.

* cargo fmt --all

* Fix warn.

* Fix articles.

Co-authored-by: Hernando Castano <castano.ha@gmail.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @HCastano @serban300
Derive bridged accounts (paritytech#781)
476e680 
* Add derivation support.

* Add custom decoder for Accounts.

* cargo fmt --all

* Fix warn.

* Fix articles.

Co-authored-by: Hernando Castano <castano.ha@gmail.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @HCastano @serban300
Derive bridged accounts (paritytech#781)
7e9f45b 
* Add derivation support.

* Add custom decoder for Accounts.

* cargo fmt --all

* Fix warn.

* Fix articles.

Co-authored-by: Hernando Castano <castano.ha@gmail.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @HCastano @serban300
Derive bridged accounts (paritytech#781)
43049bb 
* Add derivation support.

* Add custom decoder for Accounts.

* cargo fmt --all

* Fix warn.

* Fix articles.

Co-authored-by: Hernando Castano <castano.ha@gmail.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @HCastano @serban300
Derive bridged accounts (paritytech#781)
2cce6ce 
* Add derivation support.

* Add custom decoder for Accounts.

* cargo fmt --all

* Fix warn.

* Fix articles.

Co-authored-by: Hernando Castano <castano.ha@gmail.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@tomusdrw @HCastano @serban300
Derive bridged accounts (paritytech#781)
6686701 
* Add derivation support.

* Add custom decoder for Accounts.

* cargo fmt --all

* Fix warn.

* Fix articles.

Co-authored-by: Hernando Castano <castano.ha@gmail.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@tomusdrw @HCastano @serban300
Derive bridged accounts (paritytech#781)
e0083ad 
* Add derivation support.

* Add custom decoder for Accounts.

* cargo fmt --all

* Fix warn.

* Fix articles.

Co-authored-by: Hernando Castano <castano.ha@gmail.com>
bkchr pushed a commit that referenced this issue Apr 10, 2024
@tomusdrw @HCastano @bkchr
Derive bridged accounts (#781)
077e2cc 
* Add derivation support.

* Add custom decoder for Accounts.

* cargo fmt --all

* Fix warn.

* Fix articles.

Co-authored-by: Hernando Castano <castano.ha@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdimitrov tdimitrov

Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue.
Projects
parachains team board
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tdimitrov @the-right-joyce