Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework RecentDisputes and ActiveDisputes to return disputes in BTreeMap/BTreeSet instead of Vec #782

Open
tdimitrov opened this issue Sep 1, 2022 · 0 comments
Open

Rework RecentDisputes and ActiveDisputes to return disputes in BTreeMap/BTreeSet instead of Vec #782

tdimitrov opened this issue Sep 1, 2022 · 0 comments
Assignees
@tdimitrov
Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue.

Comments

@tdimitrov
Copy link
Contributor

When disputes-coordinator handles RecentDisputes and ActiveDisputes it converts BTreeMap to Vec in order to pass disputes to provisioner. The latter on the other hand converts the Vec to BTreeMap because it needs the disputes de-duplicated and sorted. This is suboptimal.

Rework the messages to use BTreeMap (for RecentDisputes) and BTreeSet for active disputes. If necessary rework also QueryCandidateVotes to use BTreeSet instead of a Vec.

This issue is a followup from paritytech/polkadot#5567 (comment)
@tdimitrov tdimitrov self-assigned this Sep 1, 2022
@tdimitrov tdimitrov mentioned this issue Sep 1, 2022
Merged
5 tasks
@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
@the-right-joyce the-right-joyce added I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. T9-parachains_protocol and removed I4-annoyance labels Aug 25, 2023
@tdimitrov tdimitrov moved this to Backlog in parachains team board Jan 29, 2024
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
@dependabot
Bump serde from 1.0.139 to 1.0.140 (paritytech#782)
7f138fe 
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.139 to 1.0.140.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.139...v1.0.140)

---
updated-dependencies:
- dependency-name: serde
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdimitrov tdimitrov

Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue.
Projects
parachains team board
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tdimitrov @the-right-joyce