Added short-benchmarks for cumulus #1183
Conversation
bkontur
added
A3-backport
|
|
||
| # run short-benchmarks for system parachain runtimes from cumulus | ||
|
|
||
| .short-benchmark-cumulus: &short-bench-cumulus |
There was a problem hiding this comment.
.short-benchmark-cumulus and .short-benchmark-polkadot could be possibly merged to .short-benchmark-template with some variables parametrization, do we want to do it?
| @@ -139,7 +139,7 @@ build-short-benchmark: | |||
| - .run-immediately | |||
| - .collect-artifacts | |||
| script: | |||
| - cargo build --profile release --locked --features=runtime-benchmarks | |||
| - cargo build --profile release --locked --features=runtime-benchmarks --bin polkadot | |||
| - mkdir -p artifacts | |||
| - target/release/polkadot --version | |||
| - cp ./target/release/polkadot ./artifacts/ | |||
There was a problem hiding this comment.
There is also mv ./target/testnet/polkadot ./artifacts/. in the step build-linux-stable, so this step overrides that, right?
Possibly we could do something like: cp ./target/release/polkadot ./artifacts/short-benchmarks/.
Also the same for polkadot-parachain binary build-linux-stable-cumulus does mv ./target/release/polkadot-parachain ./artifacts/. but also build-short-benchmark-cumulus does `cp ./target/release/polkadot-parachain ./artifacts/.
I am not missing anything, there is a possible consequence that later jobs could use binary with --features runtime-benchmarks.
|
Given that it's short, could we do it all in one job rather than giving the CI another 10+ jobs to handle? In fact could we do the relay chain ones in the same job (also rococo on the relay jobs is currently missed out fyi)? |
…' into bko-short-benchmarks-for-cumulus
I think separate jobs per runtime is much more clear or transparent. To Roocco, I dont know, it was missing also in old polkadot repo. |
There was a problem hiding this comment.
@gilescope is correct. Lets use another runners for these benchmarks
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
* master: (25 commits) fix typos (#1339) Use bandersnatch-vrfs with locked dependencies ref (#1342) Bump bs58 from 0.4.0 to 0.5.0 (#1293) Contracts: `seal0::balance` should return the free balance (#1254) Logs: add extra debug log for negative rep changes (#1205) Added short-benchmarks for cumulus (#1183) [xcm-emulator] Improve hygiene and clean up (#1301) Bump the known_good_semver group with 1 update (#1347) Renames API (#1186) Rename `polkadot-parachain` to `polkadot-parachain-primitives` (#1334) Add README to project root (#1253) Add environmental variable to track decoded instructions (#1320) Fix polkadot-node-core-pvf-prepare-worker build with jemalloc (#1315) Sassafras primitives (#1249) Restructure `dispatch` macro related exports (#1162) backing: move the min votes threshold to the runtime (#1200) Bump zstd from 0.11.2+zstd.1.5.2 to 0.12.4 (#1326) Remove `substrate_test_utils::test` (#1321) remove disable-runtime-api (#1328) [ci] add more jobs for pipeline cancel, cleanup (#1314) ...
* master: (25 commits) Markdown linter (#1309) Update `fmt` file and some authors (#1379) Bump the known_good_semver group with 1 update (#1375) Bump proc-macro-warning from 0.4.1 to 0.4.2 (#1376) feat: add futures api to `TransactionPool` (#1348) Ensure cumulus/bridges is ignored by formatter and run it (#1369) substrate: chain-spec paths corrected in zombienet tests (#1362) contracts: Update to wasmi 0.31 (#1350) [improve docs]: Template pallet (#1280) [xcm-emulator] Unignore cumulus integration tests (#1247) Fix wrong ref counting (#1358) Use cached session index to obtain executor params (#1190) fix typos (#1339) Use bandersnatch-vrfs with locked dependencies ref (#1342) Bump bs58 from 0.4.0 to 0.5.0 (#1293) Contracts: `seal0::balance` should return the free balance (#1254) Logs: add extra debug log for negative rep changes (#1205) Added short-benchmarks for cumulus (#1183) [xcm-emulator] Improve hygiene and clean up (#1301) Bump the known_good_semver group with 1 update (#1347) ...
* Added short-benchmarks for cumulus * Added `--bin` flag for short-benchmarks * fix dependency for short-benchmark-cumulus * Fixed benchmark with new XCM::V3 `MAX_INSTRUCTIONS_TO_DECODE` * Fixed benchmark for bridge messages pallets --------- Co-authored-by: alvicsam <alvicsam@gmail.com> Co-authored-by: Javier Viola <javier@parity.io> Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
This PR adds new jobs for
short-benchmarksfor system parachain runtimes in cumulus subdirectory which was added to the Cumulus repo here.