Add instruction limit when decoding XCMs #1227

franciscoaguirre · 2023-08-28T16:53:06Z

This PR makes XCM decoding fail if you go over a certain limit.

franciscoaguirre · 2023-08-28T17:20:53Z

bot rebase

command-bot · 2023-08-28T17:20:55Z

@franciscoaguirre Unknown command "rebase". Refer to help docs and/or source code.

franciscoaguirre · 2023-08-28T17:28:09Z

bot fmt

command-bot · 2023-08-28T17:28:14Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3460071 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 13-fa786025-1689-4201-8832-2f966189cf5f to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-08-28T17:28:54Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3460071 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3460071/artifacts/download.

polkadot/xcm/src/v3/mod.rs

KiChjang · 2023-08-28T20:02:36Z

Generally speaking, it is hard and sometimes impossible to measure the length of an input buffer, so what @bkchr suggested would be the best solution, even though it does change the API a bit.

franciscoaguirre · 2023-08-28T20:04:35Z

@KiChjang @bkchr I'll change this to use a BoundedVec then 👍

bkchr · 2023-08-28T20:30:35Z

I mean you can also copy the decode implementation from BoundedVec and achieve the same result without breaking the api.

franciscoaguirre · 2023-08-28T20:38:48Z

I like that. Let me try it

franciscoaguirre · 2023-08-28T20:55:45Z

bot fmt

command-bot · 2023-08-28T20:55:50Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3461674 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 14-06da03f4-bab5-41e0-901a-75d0626ec77a to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-08-28T20:59:15Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3461674 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3461674/artifacts/download.

polkadot/xcm/src/v3/mod.rs

command-bot · 2023-08-28T22:28:11Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3462613 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3462613/artifacts/download.

paritytech-cicd-pr · 2023-08-28T22:37:33Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 3/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3462629

franciscoaguirre · 2023-08-28T22:41:58Z

bot fmt

command-bot · 2023-08-28T22:42:02Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3463067 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 17-589ad713-534e-4bf4-8b3d-d4b7260f2804 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-08-28T22:43:14Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3463067 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3463067/artifacts/download.

franciscoaguirre · 2023-08-29T03:20:21Z

@bkchr @ggwpez Could you take another look?

gavofyork

If we're not going to allow the upper decode length bound to be parameterisable now, then please make an issue for it to be picked up in a later XCM version and place it in the XCM horizon.

* Add instruction limit when decoding XCMs * Make the instruction limit a constant * Use vec for buffer * ".git/.scripts/commands/fmt/fmt.sh" * Go back on std * Use BoundedVec's Decode implementation * ".git/.scripts/commands/fmt/fmt.sh" * Use an actual BoundedVec to decode XCMs * Change comment location * ".git/.scripts/commands/fmt/fmt.sh" * Remove unused imports * ".git/.scripts/commands/fmt/fmt.sh" --------- Co-authored-by: command-bot <>

* Add Beefy pallet to Rialto runtime * Add Beefy gadget to Rialto node * Add MMR pallet to Rialto runtime * Add Beefy pallet to Millau runtime * Add Beefy gadget to Millau node * Add MMR pallet to Millau runtime * Add pallet_beefy_mmr to Millau runtime * Add pallet_beefy_mmr to Rialto runtime * Implement MMR and BEEFY APIs in Rialto * fix unit tests - should_encode_bridge_send_message_call() tests for new runtime encoding resulted from newly added pallets. - runtime size_of::<Call>() slightly increased from newly added pallets. * fix grumbles * tighten clippy allowances * fix more grumbles * Add MMR RPC to Rialto and Millau nodes Also implement MmrApi in Millau runtime. * rialto: use upstream polkadot_client::RuntimeApiCollection

franciscoaguirre added 2 commits August 28, 2023 13:47

Add instruction limit when decoding XCMs

87fac9d

Make the instruction limit a constant

2a096aa

franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Aug 28, 2023

Use vec for buffer

4946278

franciscoaguirre marked this pull request as ready for review August 28, 2023 17:19

Merge branch 'master' into cis-xcm-max-instructions

dd591cf

".git/.scripts/commands/fmt/fmt.sh"

d398f91

Go back on std

1be02cf

bkchr reviewed Aug 28, 2023

View reviewed changes

polkadot/xcm/src/v3/mod.rs Show resolved Hide resolved

franciscoaguirre requested review from gavofyork, KiChjang, vstam1 and liamaharon August 28, 2023 19:59

Use BoundedVec's Decode implementation

0d2239e

".git/.scripts/commands/fmt/fmt.sh"

13ca671

Merge branch 'master' into cis-xcm-max-instructions

12f5c17

bkchr reviewed Aug 28, 2023

View reviewed changes

polkadot/xcm/src/v3/mod.rs Show resolved Hide resolved

ggwpez reviewed Aug 28, 2023

View reviewed changes

polkadot/xcm/src/v3/mod.rs Outdated Show resolved Hide resolved

Remove unused imports

f592cca

franciscoaguirre self-assigned this Aug 28, 2023

".git/.scripts/commands/fmt/fmt.sh"

f9f930f

KiChjang approved these changes Aug 29, 2023

View reviewed changes

gavofyork approved these changes Aug 29, 2023

View reviewed changes

franciscoaguirre merged commit fa3b842 into master Aug 29, 2023
11 of 13 checks passed

franciscoaguirre deleted the cis-xcm-max-instructions branch August 29, 2023 12:30

franciscoaguirre mentioned this pull request Aug 29, 2023

XCM: Allow decode length upper bound to be parameterisable #1258

Open

This was referenced Jun 5, 2024

Update polkadot-sdk from v1.7.0 to v1.11.0 moondance-labs/tanssi#573

Closed

Update polkadot-sdk from v1.10.0 to v1.11.0 moondance-labs/tanssi#577

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add instruction limit when decoding XCMs #1227

Add instruction limit when decoding XCMs #1227

franciscoaguirre commented Aug 28, 2023 •

edited

Loading

franciscoaguirre commented Aug 28, 2023

command-bot bot commented Aug 28, 2023

franciscoaguirre commented Aug 28, 2023

command-bot bot commented Aug 28, 2023 •

edited

Loading

command-bot bot commented Aug 28, 2023

KiChjang commented Aug 28, 2023

franciscoaguirre commented Aug 28, 2023

bkchr commented Aug 28, 2023

franciscoaguirre commented Aug 28, 2023

franciscoaguirre commented Aug 28, 2023

command-bot bot commented Aug 28, 2023 •

edited

Loading

command-bot bot commented Aug 28, 2023

command-bot bot commented Aug 28, 2023

paritytech-cicd-pr commented Aug 28, 2023

franciscoaguirre commented Aug 28, 2023

command-bot bot commented Aug 28, 2023 •

edited

Loading

command-bot bot commented Aug 28, 2023

franciscoaguirre commented Aug 29, 2023

gavofyork left a comment

Add instruction limit when decoding XCMs #1227

Add instruction limit when decoding XCMs #1227

Conversation

franciscoaguirre commented Aug 28, 2023 • edited Loading

franciscoaguirre commented Aug 28, 2023

command-bot bot commented Aug 28, 2023

franciscoaguirre commented Aug 28, 2023

command-bot bot commented Aug 28, 2023 • edited Loading

command-bot bot commented Aug 28, 2023

KiChjang commented Aug 28, 2023

franciscoaguirre commented Aug 28, 2023

bkchr commented Aug 28, 2023

franciscoaguirre commented Aug 28, 2023

franciscoaguirre commented Aug 28, 2023

command-bot bot commented Aug 28, 2023 • edited Loading

command-bot bot commented Aug 28, 2023

command-bot bot commented Aug 28, 2023

paritytech-cicd-pr commented Aug 28, 2023

franciscoaguirre commented Aug 28, 2023

command-bot bot commented Aug 28, 2023 • edited Loading

command-bot bot commented Aug 28, 2023

franciscoaguirre commented Aug 29, 2023

gavofyork left a comment

Choose a reason for hiding this comment

franciscoaguirre commented Aug 28, 2023 •

edited

Loading

command-bot bot commented Aug 28, 2023 •

edited

Loading

command-bot bot commented Aug 28, 2023 •

edited

Loading

command-bot bot commented Aug 28, 2023 •

edited

Loading