Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XCMP max message size check #1250

Merged
merged 14 commits into from
Dec 4, 2023
Merged

Fix XCMP max message size check #1250

Changes from 5 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
59cd8de
fix max message size
vstam1 Aug 29, 2023
7c91fee
fmt
vstam1 Aug 29, 2023
c1ddfad
fix fmt
vstam1 Aug 29, 2023
602c9f8
final fmt fix
vstam1 Aug 29, 2023
c82f2af
change to encoded_size
vstam1 Aug 29, 2023
5c5a023
Merge branch 'master' into vstam1/fix-max-message-size-limit
franciscoaguirre Dec 1, 2023
5417d0f
Add test for exceeding in XCMP
franciscoaguirre Dec 4, 2023
5568bee
Add PRDoc
franciscoaguirre Dec 4, 2023
2c62b39
Fix issue with XCM builder pattern
franciscoaguirre Dec 4, 2023
e609979
Merge branch 'master' into vstam1/fix-max-message-size-limit
franciscoaguirre Dec 4, 2023
0eafc94
".git/.scripts/commands/fmt/fmt.sh"
Dec 4, 2023
5aed8af
Change PRDoc audience
franciscoaguirre Dec 4, 2023
168e779
Change PRDoc audience
franciscoaguirre Dec 4, 2023
313a93b
Delete PRDoc
franciscoaguirre Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cumulus/pallets/xcmp-queue/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,8 @@ impl<T: Config> Pallet<T> {

let max_message_size =
T::ChannelInfo::get_channel_max(recipient).ok_or(MessageSendError::NoChannel)?;
if data.len() > max_message_size {
let format_size = format.encoded_size();
if data.len() + format_size > max_message_size {
franciscoaguirre marked this conversation as resolved.
Show resolved Hide resolved
franciscoaguirre marked this conversation as resolved.
Show resolved Hide resolved
return Err(MessageSendError::TooBig)
}

Expand Down
Loading