Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] approval-voting: batch import assignments #1517

Closed
wants to merge 15 commits into from
Closed

[WIP] approval-voting: batch import assignments #1517

wants to merge 15 commits into from

Conversation

sandreim
Copy link
Contributor

@sandreim sandreim commented Sep 12, 2023 •
edited
Loading

Fixes #730, #731

TODO:

  • Fix bugs
  • Versi load test with 6s parachain blocks.
  • fix unit tests
  • Add backpressure

@sandreim
Improve approval subsystem interface
1285e1e 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
implement ApprovalVotingMessage::CheckAssignments
6ee81c7 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Full implementation for check
810fdb9 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
some extra errors
3c3e561 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
check and import once again friends
284a7de 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
approval dist: assignment batch import
7b2cb6d 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Defer approvals for currently checking assignments
039292d 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
implement batch timer send
5b80927 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Defer approvals for queued assignment checks
0a6a521 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Ensure checks are fully serialized wrt unique assignments
149ef38 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix
dc03bc4 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim added T0-node This PR/Issue is related to the topic “node”. I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. T8-parachains_engineering labels Sep 12, 2023
@sandreim
Fix distribution bug and more logging
6178c95 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Fix bugs and add more logs
b8ecdfb 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Copy link
Contributor Author

At first run, doesn't seem to improve things enough to sustain the load of 50 cores, 300 validators and 6s block times.

@sandreim
Fix block map usage vs finality race
e2d4c69 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix build
e08a0e0 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3676277

@rphmeier rphmeier mentioned this pull request Sep 13, 2023
Closed
@sandreim sandreim mentioned this pull request Sep 18, 2023
Closed
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
reuse lane_id variable (paritytech#1517)
1a4e82a
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
reuse lane_id variable (paritytech#1517)
b49235d
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
reuse lane_id variable (paritytech#1517)
37817c4
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
reuse lane_id variable (paritytech#1517)
cbda05d
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
reuse lane_id variable (paritytech#1517)
eabe31f
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
reuse lane_id variable (paritytech#1517)
39eb6b0
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
reuse lane_id variable (paritytech#1517)
c87f1b7
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
reuse lane_id variable (paritytech#1517)
d832801
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
reuse lane_id variable (paritytech#1517)
85e5fa3
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
reuse lane_id variable (paritytech#1517)
3fbf750
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
reuse lane_id variable (paritytech#1517)
04f19f5
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
reuse lane_id variable (paritytech#1517)
8f74c07
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@svyatonik @bkchr
reuse lane_id variable (#1517)
057fd6c
This was referenced Jun 5, 2024
Closed
Closed
@bkchr
Copy link
Member

bkchr commented Jul 16, 2024

@sandreim can we close this?

@sandreim
Copy link
Contributor Author

Yes

@sandreim sandreim closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

approval-voting: experiment with batching signature checks
4 participants
@sandreim @paritytech-cicd-pr @bkchr @the-right-joyce