Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UMP pricing #1556

Merged
merged 78 commits into from
Oct 12, 2023
Merged

Add UMP pricing #1556

merged 78 commits into from
Oct 12, 2023

Conversation

franciscoaguirre
Copy link
Contributor

@franciscoaguirre franciscoaguirre commented Sep 14, 2023 •
edited
Loading

Description

Adds pricing for UMP, much like it was added for DMP in paritytech/polkadot#6843 and HRMP in #1234.

This means all system parachains now charge for fees when sending messages to the relay chain.

Note for reviewers

Most changed files are tests, the most relevant files are:

  • cumulus/pallets/parachain-system/src/lib.rs <- ParachainSystem pallet now tracks the exponential factor for the delivery fees
  • All the xcm_config files <- They add PriceForParentDelivery as the price on the ParentAsUmp router

TODO

  • Track fee in ParachainSystem
  • Add ExponentialPrice in UMP router in configs

@franciscoaguirre franciscoaguirre changed the base branch from master to kckyeung/xcm-fees-manager September 14, 2023 04:27
@franciscoaguirre franciscoaguirre changed the title Cis ump pricing Add UMP pricing Sep 14, 2023
@franciscoaguirre
Copy link
Contributor Author

bot fmt

@command-bot
Copy link

command-bot bot commented Sep 14, 2023 •
edited
Loading

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3703290 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-b5f3fa31-1b83-47e7-a4a9-662f186abf59 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Sep 14, 2023

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3703290 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3703290/artifacts/download.

@franciscoaguirre franciscoaguirre self-assigned this Sep 15, 2023
@franciscoaguirre franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Sep 15, 2023
@command-bot
Copy link

command-bot bot commented Oct 11, 2023

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3937649 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3937649/artifacts/download.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3945768

@franciscoaguirre
Copy link
Contributor Author

bot fmt

@command-bot
Copy link

command-bot bot commented Oct 12, 2023 •
edited
Loading

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3948850 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 33-107841bd-4bcf-4a3d-a054-8b2cb5483f41 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Oct 12, 2023

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3948850 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3948850/artifacts/download.

@franciscoaguirre franciscoaguirre merged commit 73ad0fc into kckyeung/xcm-fees-manager Oct 12, 2023
99 of 107 checks passed
@franciscoaguirre franciscoaguirre deleted the cis-ump-pricing branch October 12, 2023 13:22
@xlc
Copy link
Contributor

xlc commented Oct 12, 2023

Can someone write some explanations so I don't need to read all the code to understand exactly the impact of this?
How does this impact users of system parachains? Will they be charged additional fees for some actions?
How does this impact parachains teams? Any recommendations of the parameters?
How does this impact UI devs? How do they query/estimate the fees to show the fees to users?

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@bkontur @serban300
Reexport paste from sp-runtime in bp-runtime to aviod including `…
c6fd20c 
…paste` dependency everywhere (paritytech#1556)

* Reexport paste from `sp-runtime` in `bp-runtime` to aviod including `paste` dependency everywhere

* Add import `bp_runtime` to macro calls: decl_bridge_finality_runtime_apis/decl_bridge_messages_runtime_apis
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@bkontur @serban300
Reexport paste from sp-runtime in bp-runtime to aviod including `…
66ee89f 
…paste` dependency everywhere (paritytech#1556)

* Reexport paste from `sp-runtime` in `bp-runtime` to aviod including `paste` dependency everywhere

* Add import `bp_runtime` to macro calls: decl_bridge_finality_runtime_apis/decl_bridge_messages_runtime_apis
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@bkontur @serban300
Reexport paste from sp-runtime in bp-runtime to aviod including `…
e34b2af 
…paste` dependency everywhere (paritytech#1556)

* Reexport paste from `sp-runtime` in `bp-runtime` to aviod including `paste` dependency everywhere

* Add import `bp_runtime` to macro calls: decl_bridge_finality_runtime_apis/decl_bridge_messages_runtime_apis
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@bkontur @serban300
Reexport paste from sp-runtime in bp-runtime to aviod including `…
025d799 
…paste` dependency everywhere (paritytech#1556)

* Reexport paste from `sp-runtime` in `bp-runtime` to aviod including `paste` dependency everywhere

* Add import `bp_runtime` to macro calls: decl_bridge_finality_runtime_apis/decl_bridge_messages_runtime_apis
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@bkontur @serban300
Reexport paste from sp-runtime in bp-runtime to aviod including `…
fb26097 
…paste` dependency everywhere (paritytech#1556)

* Reexport paste from `sp-runtime` in `bp-runtime` to aviod including `paste` dependency everywhere

* Add import `bp_runtime` to macro calls: decl_bridge_finality_runtime_apis/decl_bridge_messages_runtime_apis
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@bkontur @serban300
Reexport paste from sp-runtime in bp-runtime to aviod including `…
4c9891f 
…paste` dependency everywhere (paritytech#1556)

* Reexport paste from `sp-runtime` in `bp-runtime` to aviod including `paste` dependency everywhere

* Add import `bp_runtime` to macro calls: decl_bridge_finality_runtime_apis/decl_bridge_messages_runtime_apis
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@bkontur @serban300
Reexport paste from sp-runtime in bp-runtime to aviod including `…
56ccf6b 
…paste` dependency everywhere (paritytech#1556)

* Reexport paste from `sp-runtime` in `bp-runtime` to aviod including `paste` dependency everywhere

* Add import `bp_runtime` to macro calls: decl_bridge_finality_runtime_apis/decl_bridge_messages_runtime_apis
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@bkontur @serban300
Reexport paste from sp-runtime in bp-runtime to aviod including `…
e3a603b 
…paste` dependency everywhere (paritytech#1556)

* Reexport paste from `sp-runtime` in `bp-runtime` to aviod including `paste` dependency everywhere

* Add import `bp_runtime` to macro calls: decl_bridge_finality_runtime_apis/decl_bridge_messages_runtime_apis
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@bkontur @serban300
Reexport paste from sp-runtime in bp-runtime to aviod including `…
1b497fb 
…paste` dependency everywhere (paritytech#1556)

* Reexport paste from `sp-runtime` in `bp-runtime` to aviod including `paste` dependency everywhere

* Add import `bp_runtime` to macro calls: decl_bridge_finality_runtime_apis/decl_bridge_messages_runtime_apis
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@bkontur @serban300
Reexport paste from sp-runtime in bp-runtime to aviod including `…
a190e2f 
…paste` dependency everywhere (paritytech#1556)

* Reexport paste from `sp-runtime` in `bp-runtime` to aviod including `paste` dependency everywhere

* Add import `bp_runtime` to macro calls: decl_bridge_finality_runtime_apis/decl_bridge_messages_runtime_apis
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@bkontur @serban300
Reexport paste from sp-runtime in bp-runtime to aviod including `…
d7b7c9c 
…paste` dependency everywhere (paritytech#1556)

* Reexport paste from `sp-runtime` in `bp-runtime` to aviod including `paste` dependency everywhere

* Add import `bp_runtime` to macro calls: decl_bridge_finality_runtime_apis/decl_bridge_messages_runtime_apis
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@bkontur @serban300
Reexport paste from sp-runtime in bp-runtime to aviod including `…
5ce75bb 
…paste` dependency everywhere (paritytech#1556)

* Reexport paste from `sp-runtime` in `bp-runtime` to aviod including `paste` dependency everywhere

* Add import `bp_runtime` to macro calls: decl_bridge_finality_runtime_apis/decl_bridge_messages_runtime_apis
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@bkontur @bkchr
Reexport paste from sp-runtime in bp-runtime to aviod including `…
793321f 
…paste` dependency everywhere (#1556)

* Reexport paste from `sp-runtime` in `bp-runtime` to aviod including `paste` dependency everywhere

* Add import `bp_runtime` to macro calls: decl_bridge_finality_runtime_apis/decl_bridge_messages_runtime_apis
This was referenced Jun 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamaharon liamaharon liamaharon approved these changes

@KiChjang KiChjang KiChjang approved these changes

@bkontur bkontur Awaiting requested review from bkontur

@NachoPal NachoPal Awaiting requested review from NachoPal

@athei athei Awaiting requested review from athei

Assignees

@franciscoaguirre franciscoaguirre

Labels
T6-XCM This PR/Issue is related to XCM.
Projects
Security Audit (PRs) - SRLabs
Status: Audited
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@franciscoaguirre @paritytech-cicd-pr @xlc @KiChjang @liamaharon