Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation checklist document for Substrate #1583
Add deprecation checklist document for Substrate #1583
Changes from 8 commits
20c84cb
01bdc53
46a7f52
2e38826
00f4fc4
93bbecc
c477bea
752209b
1a1b74f
94f200a
b01bed7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not recommend to set this time frame as a rule, it's good if your team is so organised that they know when they'll be ready to deprecate the code, but in some cases we can't really tell when this is gonna happen.. instead it's deprecated as soon as there's a replacement ready to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, absolutely. The 6 months period is for the removal of the deprecated code, not for the deprecation itself.
When a piece of code is deprecated, it should be technically possible to be removed straight away. This period is for the downstream developers to have time to update their code. They should know when to expect the removal to happen.
Also, this timeframe (6 months or whatever was chosen) is only a lower bound, that's why the notice should look like
[DEPRECATED] will be removed after [DATE]
. This means that we are free to remove a code in 7 or 8 months even if we said that it will be removed after 6 months from now, but we shall not remove it before those 6 months.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to say here where else this should be mentioned then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should tie this into https://forum.parity.io/t/pr-documentation-prdoc/2065?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that post isn't public, that's why I have linked to the documentation section of the CONTRIBUTING doc, which is a summary of it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, maybe someone from devrel can help us here? @sacha-l @aaronbassett