Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pallet-xcm: enhance reserve_transfer_assets to support remote reserves #1672

Merged

Commits on Sep 29, 2023

  1. Configuration menu
    Copy the full SHA
    43ef694 View commit details
    Browse the repository at this point in the history
  2. pallet-xcm: filter assets teleports based on XcmExecutor configuration

    Add AssetTransferFilter trait for configuring transfer types.
    Implement it for XcmExecutor based on existing executor teleports and
    reserves configuration.
    Filter assets on pallet-xcm::limited_teleport_assets() based on above.
    acatangiu committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    945b34c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ce215a1 View commit details
    Browse the repository at this point in the history
  4. pallet-xcm: enchance reserve_transfer_assets() to support various res…

    …erves
    
    'reserve_transfer_assets()' assumed all provided `assets` (fees included)
    have same, local reserve.
    
    This commit enhances the extrinsic to support various scenarios:
    - transferring assets with reserve on destination,
    - transferring assets with reserve on remote/third-party chain,
    - transferring assets with reserve different than the reserve of the
      asset to be used as fees - meaning can use to transfer random asset with
      random reserve while using DOT for fees on all involved chains, even
      if local chain is NOT a reserve location of DOT (aka most chains),
    - transferring assets with any type of local/dest/remote reserve while
      using fees which can be teleported between involved chains.
    
    All of the above is done by pallet inner logic without the user having to
    specify which scenario/reserves/teleports/etc. The correct scenario and
    corresponding XCM programs are identified, and respectively, built automatically
    based on runtime configuration of trusted teleporters and trusted reserves.
    
    Current limitations:
    - while `fees` and "non-fee" `assets` CAN have different reserves (or fees CAN
      be teleported), the remaining "non-fee" `assets` CANNOT have different
      reserve locations (this is also implicitly enforced by
      `MAX_ASSETS_FOR_TRANSFER=2`, but this can be safely increased in the future).
    - `fees` and "non-fee" `assets` CANNOT have **different remote** reserves (this
      can also be supported in the future, but adds even more complexity while
      possibly not being worth it - we'll see what the future holds).
    acatangiu committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    a5fd746 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c581d76 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    fe52d48 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5d847e3 View commit details
    Browse the repository at this point in the history
  8. add test cases plan

    acatangiu committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    026a779 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4465c65 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2392dd9 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    67daafe View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    88b3024 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    513e15a View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    19eec17 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    1687c53 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    abf029d View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    576c770 View commit details
    Browse the repository at this point in the history
  18. fix some typos

    acatangiu committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    280c4b1 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    bab8fc2 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    f7a4a2e View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    f88de5e View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    f7abb0a View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    7b920ec View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    3130566 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    1b17e84 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    84e213a View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    ce00c28 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    1dfcd01 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Merge branch 'master' of github.com:paritytech/polkadot-sdk into pall…

    …et-xcm-fully-support-reserve-transfers
    acatangiu committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    24f9b72 View commit details
    Browse the repository at this point in the history
  2. pallet-xcm: fix benchmarks

    acatangiu committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    022ef71 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9827c3b View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. address review comments

    acatangiu committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    23588a8 View commit details
    Browse the repository at this point in the history
  2. expose TransferType through XcmExecutor::traits::AssetTransferSupport…

    … instead of pallet_xcm
    acatangiu committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    931e093 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'master' of github.com:paritytech/polkadot-sdk into pall…

    …et-xcm-fully-support-reserve-transfers
    acatangiu committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    bf39726 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Merge branch 'master' of github.com:paritytech/polkadot-sdk into pall…

    …et-xcm-fully-support-reserve-transfers
    acatangiu committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    8ac30aa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    09badd6 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Merge branch 'master' of github.com:paritytech/polkadot-sdk into pall…

    …et-xcm-fully-support-reserve-transfers
    acatangiu committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    648ba8a View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. fix merge damage

    acatangiu committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    f8e8b4a View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. fmt

    acatangiu committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    71bd4b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4ab90f7 View commit details
    Browse the repository at this point in the history
  3. address review comments

    acatangiu committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    3070994 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f045c73 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'master' of github.com:paritytech/polkadot-sdk into pall…

    …et-xcm-fully-support-reserve-transfers
    acatangiu committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    fe93ef4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d1a9709 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Configuration menu
    Copy the full SHA
    50d844f View commit details
    Browse the repository at this point in the history
  2. fix AHs tests

    acatangiu committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    0bf64e6 View commit details
    Browse the repository at this point in the history
  3. AHs: fix emulated tests

    acatangiu committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    c711961 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    67929a5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    dd46f23 View commit details
    Browse the repository at this point in the history
  6. fix clippy

    acatangiu committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    e8cbcb9 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Configuration menu
    Copy the full SHA
    d725103 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3d97f19 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ac3773e View commit details
    Browse the repository at this point in the history
  4. fixes plus tests

    acatangiu committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    cb6f53a View commit details
    Browse the repository at this point in the history
  5. fix pallet-xcm tests

    acatangiu committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    560d788 View commit details
    Browse the repository at this point in the history
  6. fix AHs tests

    acatangiu committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    3bc2d73 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Merge branch 'master' of github.com:paritytech/polkadot-sdk into pall…

    …et-xcm-fully-support-reserve-transfers
    acatangiu committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    f838cd5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bd60203 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Merge branch 'master' of github.com:paritytech/polkadot-sdk into pall…

    …et-xcm-fully-support-reserve-transfers
    acatangiu committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    2e71447 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    371ac2d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9b58ff0 View commit details
    Browse the repository at this point in the history
  4. Revert "try add pallet-assets for benchmarking to rococo"

    This reverts commit c82330b.
    acatangiu committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    942977e View commit details
    Browse the repository at this point in the history
  5. pallet-xcm benchmarking: most chains do not have pallet-assets, use p…

    …allet-balances instead
    acatangiu committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    3b9965b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    adcd688 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    eca0c3e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b648df2 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    da7d8ff View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2023

  1. Configuration menu
    Copy the full SHA
    8d85faa View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Update polkadot/xcm/xcm-executor/src/traits/asset_transfer.rs

    Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
    acatangiu and franciscoaguirre authored Oct 30, 2023
    Configuration menu
    Copy the full SHA
    37552fd View commit details
    Browse the repository at this point in the history
  2. Update polkadot/xcm/pallet-xcm/src/lib.rs

    Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
    acatangiu and franciscoaguirre authored Oct 30, 2023
    Configuration menu
    Copy the full SHA
    6714d39 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a79ed78 View commit details
    Browse the repository at this point in the history
  4. fmt

    acatangiu committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    7a61129 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Update polkadot/xcm/xcm-builder/src/barriers.rs

    Co-authored-by: Branislav Kontur <bkontur@gmail.com>
    acatangiu and bkontur authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    0f76530 View commit details
    Browse the repository at this point in the history
  2. Update polkadot/xcm/pallet-xcm/src/lib.rs

    Co-authored-by: Branislav Kontur <bkontur@gmail.com>
    acatangiu and bkontur authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    9d3f2dd View commit details
    Browse the repository at this point in the history
  3. Update polkadot/xcm/pallet-xcm/src/lib.rs

    Co-authored-by: Branislav Kontur <bkontur@gmail.com>
    acatangiu and bkontur authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    9feb4b0 View commit details
    Browse the repository at this point in the history
  4. Update polkadot/xcm/pallet-xcm/src/lib.rs

    Co-authored-by: Branislav Kontur <bkontur@gmail.com>
    acatangiu and bkontur authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    0a38b70 View commit details
    Browse the repository at this point in the history
  5. fmt

    acatangiu committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    02447d0 View commit details
    Browse the repository at this point in the history
  6. Merge branch 'master' of github.com:paritytech/polkadot-sdk into pall…

    …et-xcm-fully-support-reserve-transfers
    acatangiu committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    84e3e29 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Configuration menu
    Copy the full SHA
    b67cb0f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ec87ce6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    da3c12e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ac9bf49 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e85e339 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9f7538d View commit details
    Browse the repository at this point in the history
  7. clippy

    acatangiu committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    45279cc View commit details
    Browse the repository at this point in the history
  8. Merge branch 'master' of github.com:paritytech/polkadot-sdk into pall…

    …et-xcm-fully-support-reserve-transfers
    acatangiu committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    59cf104 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Merge branch 'master' of github.com:paritytech/polkadot-sdk into pall…

    …et-xcm-fully-support-reserve-transfers
    acatangiu committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    e9c7205 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ba36f8 View commit details
    Browse the repository at this point in the history
  3. fix merge damage

    acatangiu committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    7728527 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a4089c8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    44e1918 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Configuration menu
    Copy the full SHA
    a59ccf3 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' of github.com:paritytech/polkadot-sdk into pall…

    …et-xcm-fully-support-reserve-transfers
    acatangiu committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    27c7cea View commit details
    Browse the repository at this point in the history
  3. fix merge damage

    acatangiu committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    582c616 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    94aaffd View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2023

  1. Configuration menu
    Copy the full SHA
    fe2cb6a View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. pallet-xcm: add trace logs

    acatangiu committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    2ebefc0 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' of github.com:paritytech/polkadot-sdk into pall…

    …et-xcm-fully-support-reserve-transfers
    acatangiu committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    839af41 View commit details
    Browse the repository at this point in the history
  3. fix runtime-benchmarks

    acatangiu committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    56c52f1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    669e109 View commit details
    Browse the repository at this point in the history
  5. pallet-xcm: fix tests

    acatangiu committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    ba91cd6 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Configuration menu
    Copy the full SHA
    8951238 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dd2a06f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6d67ea1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    db1e826 View commit details
    Browse the repository at this point in the history
  5. rename fns

    acatangiu committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    54d7465 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    39e7b66 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Configuration menu
    Copy the full SHA
    ceddec5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7f78c73 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'master' of github.com:paritytech/polkadot-sdk into pall…

    …et-xcm-fully-support-reserve-transfers
    acatangiu committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    45131b1 View commit details
    Browse the repository at this point in the history
  4. fix merge damage

    acatangiu committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    cb8226d View commit details
    Browse the repository at this point in the history
  5. Merge branch 'master' of github.com:paritytech/polkadot-sdk into pall…

    …et-xcm-fully-support-reserve-transfers
    acatangiu committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    d0c8944 View commit details
    Browse the repository at this point in the history
  6. fix merge damage

    acatangiu committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    c5522e4 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Merge branch 'master' of github.com:paritytech/polkadot-sdk into pall…

    …et-xcm-fully-support-reserve-transfers
    acatangiu committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    9827904 View commit details
    Browse the repository at this point in the history
  2. fix merge damage

    acatangiu committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    0cc32e3 View commit details
    Browse the repository at this point in the history