Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change prepare worker to use fork instead of threads #1685

Merged
merged 58 commits into from
Nov 14, 2023

Commits on Sep 24, 2023

  1. Configuration menu
    Copy the full SHA
    6009a85 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cbed258 View commit details
    Browse the repository at this point in the history
  3. fix fmt and int cast

    jpserrat committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    08c7766 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Configuration menu
    Copy the full SHA
    40429a2 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2023

  1. Configuration menu
    Copy the full SHA
    4300566 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Merge branch 'master' of github.com:paritytech/polkadot-sdk into jpse…

    …rrat-pvf-fork-instead-threads
    jpserrat committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    92d25a2 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Configuration menu
    Copy the full SHA
    d0a261a View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' of github.com:paritytech/polkadot-sdk into jpse…

    …rrat-pvf-fork-instead-threads
    jpserrat committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    9970ef8 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Configuration menu
    Copy the full SHA
    5f100d9 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' of github.com:paritytech/polkadot-sdk into jpse…

    …rrat-pvf-fork-instead-threads
    jpserrat committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    7b9421c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e64ff83 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    462d73c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7ef719d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b0fa175 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Configuration menu
    Copy the full SHA
    220f069 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Configuration menu
    Copy the full SHA
    96de656 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2023

  1. Merge branch 'master' of github.com:paritytech/polkadot-sdk into jpse…

    …rrat-pvf-fork-instead-threads
    jpserrat committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    ab51e84 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Configuration menu
    Copy the full SHA
    6c96fd9 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2023

  1. Configuration menu
    Copy the full SHA
    fdb3462 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2023

  1. Configuration menu
    Copy the full SHA
    f4bea3a View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Configuration menu
    Copy the full SHA
    6615598 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2196c5f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1682ed0 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Configuration menu
    Copy the full SHA
    5c9b1d8 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Some minor updates

    mrcnski committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    962fccb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    45b0648 View commit details
    Browse the repository at this point in the history
  3. Clean up fork usage a bit

    mrcnski committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    7baf706 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7687015 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Configuration menu
    Copy the full SHA
    c584441 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0d5eb73 View commit details
    Browse the repository at this point in the history
  3. Update for seccomp (add detection for job death); fix some errors

    - Changed error for pipe read failure (job died)
    - Updated seccomp detection (IoErr no longer means job died)
    - Updated test
    - Confirmed manually that a seccomp violation (with process killing) result in a
      JobDied error.
    - Updated some other errors (still more to do)
    mrcnski committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    a932a7c View commit details
    Browse the repository at this point in the history
  4. Some clarifications

    mrcnski committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    7e1414e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d9fcb5d View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Fix bench

    mrcnski committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    f830b05 View commit details
    Browse the repository at this point in the history
  2. cargo fmt

    mrcnski committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    d9fcc7c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7d86911 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3b855d8 View commit details
    Browse the repository at this point in the history
  5. Fix some test failures

    mrcnski committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    0c04842 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2023

  1. Configuration menu
    Copy the full SHA
    87e96d0 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'jpserrat-pvf-fork-instead-threads' of github.com:Jpserr…

    …at/polkadot-sdk into jpserrat-pvf-fork-instead-threads
    jpserrat committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    9e3d65c View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2023

  1. Configuration menu
    Copy the full SHA
    de87f5f View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'Jpserrat/jpserrat-pvf-fork-instead-thre…

    …ads' into jpserrat-pvf-fork-instead-threads
    mrcnski committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    2e497a7 View commit details
    Browse the repository at this point in the history
  3. cargo fmt

    mrcnski committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    6bd7d20 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1fb8c13 View commit details
    Browse the repository at this point in the history
  5. Fix some tests

    mrcnski committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    9c666b4 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Make error reporting more robust and secure

    - Created a `JobResponse` and `JobError` types for the job to self-report its
    status. Note that these reports must be treated as untrusted due to the
    job running untrusted code. Previously some errors from the job were being
    treated as internal! That's why it's important that the error handling here is
    robust and accurate.
    
    - Made `WorkerResponse::JobError(String)` hold any unexpected error from the job
    process.
    
    - Renamed some of the response types and variants to be more accurate.
    mrcnski committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    8c7c519 View commit details
    Browse the repository at this point in the history
  2. Some fixes

    mrcnski committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    af96dfa View commit details
    Browse the repository at this point in the history
  3. 2 Configuration menu
    Copy the full SHA
    67736c4 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Some fixes

    mrcnski committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    e25344c View commit details
    Browse the repository at this point in the history
  2. Fix prechecking_out_of_memory test

    There were several simultaneous issues:
    
    - We were using the wrong exit calls in the allocation failure handler. This is
    some evil stuff that I don't understand.
    
    - We were ignoring responses from the child when the exit status was 1
    
    - We were sending a response encoded with a length prefix, but not decoding with
    `framed_recv`
    mrcnski committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    203ce25 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    de7d19d View commit details
    Browse the repository at this point in the history
  4. Fix test

    mrcnski committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    cec6477 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    89cfd2e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    58b814c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a28cf2e View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Address review comments

    mrcnski committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    b03c695 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Configuration menu
    Copy the full SHA
    8070074 View commit details
    Browse the repository at this point in the history
  2. Update impl guide

    mrcnski committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    05555e7 View commit details
    Browse the repository at this point in the history