Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arkworks Elliptic Curve utils overhaul #1870

Merged
merged 6 commits into from
Oct 16, 2023
Merged

Arkworks Elliptic Curve utils overhaul #1870

merged 6 commits into from
Oct 16, 2023

Conversation

davxy
Copy link
Member

@davxy davxy commented Oct 13, 2023 •
edited
Loading

  • Removal of Arkworks unit tests. These tests were just testing the arkworks upstream implementation which should be assumed correct. This is not the place to test well known dependencies.
  • Removal of some over-engineering. We just store the calls to Arkworks in one file. Per-curve sources are not required.
  • Docs formatting

I also took the opportunity to bump the bandersnatch-vrfs crate revision internally providing some new shiny stuff.

@davxy davxy requested a review from a team October 13, 2023 16:34
@paritytech paritytech deleted a comment from paritytech-cicd-pr Oct 13, 2023
@davxy davxy self-assigned this Oct 13, 2023
@davxy davxy added the T0-node This PR/Issue is related to the topic “node”. label Oct 13, 2023
@burdges
Copy link

burdges commented Oct 13, 2023

LGTM

bkchr
bkchr approved these changes Oct 15, 2023
View reviewed changes
substrate/primitives/crypto/ec-utils/src/utils.rs
g1: Vec<u8>,
g2: Vec<u8>,
) -> Result<Vec<u8>, ()> {
pub fn multi_miller_loop<Curve: Pairing>(g1: Vec<u8>, g2: Vec<u8>) -> Result<Vec<u8>, ()> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these functions could have stayed pub(crate)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As they don't have any usage outside of this crate, I'd answer yes.
I removed pub(crate) because the utils module itself is not public.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah fine.

@davxy davxy merged commit 38ef04e into master Oct 16, 2023
131 checks passed
@davxy davxy deleted the davxy-ec-utils-overhaul branch October 16, 2023 08:43
ordian added a commit that referenced this pull request Oct 16, 2023
@ordian
Merge branch 'master' into tsv-disabling-backing
c44093d 
* master: (54 commits)
  Publish `xcm-emulator` crate (#1881)
  Adding migrations to clean Rococo Gov 1 storage & reserved funds (#1849)
  Arkworks Elliptic Curve utils overhaul (#1870)
  Fix typos (#1878)
  fix: GoAhead signal only set when runtime upgrade is enacted from parachain side (#1176)
  Refactor staking ledger (#1484)
  Paired-key Crypto Scheme (#1705)
  Include polkadot version in artifact path (#1828)
  add link to rfc-0001 in broker README (#1862)
  Discard `Executor` (#1855)
  Macros to use path instead of ident (#1474)
  Remove clippy clone-double-ref lint noise (#1860)
  Refactor alliance benchmarks to v2 (#1868)
  Check executor params coherence (#1774)
  frame: use derive-impl for beefy and mmr pallets (#1867)
  sc-consensus-beefy: improve gossip logic (#1852)
  Adds instance support for composite enums (#1857)
  Fix links to implementers' guide (#1865)
  Disabled validators runtime API (#1257)
  Adding `try_state` hook for `Treasury` pallet (#1820)
  ...
ordian added a commit that referenced this pull request Oct 16, 2023
@ordian
Merge branch 'tsv-disabling-backing' into ao-disabling-statement-dist…
b67c19f 
…ribution

* tsv-disabling-backing: (54 commits)
  Publish `xcm-emulator` crate (#1881)
  Adding migrations to clean Rococo Gov 1 storage & reserved funds (#1849)
  Arkworks Elliptic Curve utils overhaul (#1870)
  Fix typos (#1878)
  fix: GoAhead signal only set when runtime upgrade is enacted from parachain side (#1176)
  Refactor staking ledger (#1484)
  Paired-key Crypto Scheme (#1705)
  Include polkadot version in artifact path (#1828)
  add link to rfc-0001 in broker README (#1862)
  Discard `Executor` (#1855)
  Macros to use path instead of ident (#1474)
  Remove clippy clone-double-ref lint noise (#1860)
  Refactor alliance benchmarks to v2 (#1868)
  Check executor params coherence (#1774)
  frame: use derive-impl for beefy and mmr pallets (#1867)
  sc-consensus-beefy: improve gossip logic (#1852)
  Adds instance support for composite enums (#1857)
  Fix links to implementers' guide (#1865)
  Disabled validators runtime API (#1257)
  Adding `try_state` hook for `Treasury` pallet (#1820)
  ...
@ggwpez ggwpez mentioned this pull request Oct 16, 2023
Merged
1 task
@kiltbot kiltbot mentioned this pull request Nov 7, 2023
Closed
@ahmadkaouk ahmadkaouk mentioned this pull request Nov 16, 2023
Closed
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@davxy
Arkworks Elliptic Curve utils overhaul (paritytech#1870)
31db70d 
- Removal of Arkworks unit tests. These tests were just testing the
arkworks upstream implementation which should be assumed correct. This
is not the place to test well known dependencies.
- Removal of some over-engineering. We just store the calls to Arkworks
in one file. Per-curve sources are not required.
- Docs formatting

---

I also took the opportunity to bump the `bandersnatch-vrfs` crate
revision internally providing some new shiny stuff.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Mar 26, 2024
@svyatonik
More tests for message pallet weights (paritytech#1870)
5219b56 
* more tests for message pallet weights

* move tests to ensure_weights_are_correct

* removed extra tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Mar 27, 2024
@svyatonik
More tests for message pallet weights (paritytech#1870)
0b9188b 
* more tests for message pallet weights

* move tests to ensure_weights_are_correct

* removed extra tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik
More tests for message pallet weights (paritytech#1870)
3cb16fb 
* more tests for message pallet weights

* move tests to ensure_weights_are_correct

* removed extra tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
More tests for message pallet weights (paritytech#1870)
1bedbf6 
* more tests for message pallet weights

* move tests to ensure_weights_are_correct

* removed extra tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
More tests for message pallet weights (paritytech#1870)
2a9b05c 
* more tests for message pallet weights

* move tests to ensure_weights_are_correct

* removed extra tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
More tests for message pallet weights (paritytech#1870)
872b4c9 
* more tests for message pallet weights

* move tests to ensure_weights_are_correct

* removed extra tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
More tests for message pallet weights (paritytech#1870)
67fd0ac 
* more tests for message pallet weights

* move tests to ensure_weights_are_correct

* removed extra tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
More tests for message pallet weights (paritytech#1870)
907e3b9 
* more tests for message pallet weights

* move tests to ensure_weights_are_correct

* removed extra tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
More tests for message pallet weights (paritytech#1870)
645ca63 
* more tests for message pallet weights

* move tests to ensure_weights_are_correct

* removed extra tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
More tests for message pallet weights (paritytech#1870)
9236233 
* more tests for message pallet weights

* move tests to ensure_weights_are_correct

* removed extra tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
More tests for message pallet weights (paritytech#1870)
fd69520 
* more tests for message pallet weights

* move tests to ensure_weights_are_correct

* removed extra tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
More tests for message pallet weights (paritytech#1870)
a5e9856 
* more tests for message pallet weights

* move tests to ensure_weights_are_correct

* removed extra tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
More tests for message pallet weights (paritytech#1870)
58cd517 
* more tests for message pallet weights

* move tests to ensure_weights_are_correct

* removed extra tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
More tests for message pallet weights (paritytech#1870)
12b9ec1 
* more tests for message pallet weights

* move tests to ensure_weights_are_correct

* removed extra tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
More tests for message pallet weights (paritytech#1870)
9968f60 
* more tests for message pallet weights

* move tests to ensure_weights_are_correct

* removed extra tests
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@svyatonik @bkchr
More tests for message pallet weights (#1870)
89bb368 
* more tests for message pallet weights

* move tests to ensure_weights_are_correct

* removed extra tests
This was referenced Jun 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

@skunert skunert skunert approved these changes

@koute koute koute approved these changes

@andresilva andresilva Awaiting requested review from andresilva

@michalkucharczyk michalkucharczyk Awaiting requested review from michalkucharczyk

Assignees

@davxy davxy

Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
SDK Node
Status: done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davxy @burdges @koute @skunert @bkchr