-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use prebuilt try-runtime binary in CI #1898
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvicsam
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
liamaharon
changed the title
[WIP / DNM] Use prebuilt try-runtime binary in CI
Use prebuilt try-runtime binary in CI
Oct 18, 2023
rcny
approved these changes
Oct 18, 2023
Note that once caching lands in the monorepo, it will also speed up such CI patterns. |
ggwpez
approved these changes
Oct 18, 2023
skunert
added a commit
to skunert/polkadot-sdk
that referenced
this pull request
Oct 19, 2023
Use prebuilt try-runtime binary in CI (paritytech#1898) `cargo install` takes a long time in CI. We want to run it relatively frequently without chewing through so much compute (see paritytech/ci_cd#771) so I added automatic binary releases to the try-runtime-cli repo. A small added benefit is we can use it in our existing `on-runtime-upgrade` checks, which should cut their execution time by about half. Cumulus: Allow aura to use initialized collation request receiver (paritytech#1911) When launching our [small network](https://github.com/paritytech/polkadot-sdk/blob/master/cumulus/zombienet/examples/small_network.toml) for testing the node was crashing here shortly after launch: https://github.com/paritytech/polkadot-sdk/blob/5cdd819ed295645958afd9d937d989978fd0c84e/polkadot/node/collation-generation/src/lib.rs#L140 After changes in paritytech#1788 for the asset hub collator we are waiting for blocks of the shell runtime to pass before we initialize aura. However, this means that we attempted to initialize the collation related relay chain subsystems twice, leading to the error. I modified Aura to let it optionally take an already initialized stream of collation requests. Remove comments
ordian
added a commit
that referenced
this pull request
Oct 20, 2023
* tsv-disabling: (39 commits) Handling of disabled validators in backing subsystem (#1259) Switch trie cache random seed (#1935) Expose prometheus metrics for minimal-relay-chain node in collators (#1942) Do not force collators to update after enabling async backing (#1920) Pin PRDoc image to v0.0.5 until we are ready for v0.0.6 (#1947) [prdoc] Start BEEFY gadget by default for Polkadot nodes (#1945) Update bridges subtree (#1944) bump zombienet version (#1931) [FRAME] Message Queue use proper overweight limit (#1873) Cumulus: Allow aura to use initialized collation request receiver (#1911) Use prebuilt try-runtime binary in CI (#1898) Update kusama/polkadot bootnodes (#1895) Introduce XcmFeesToAccount fee manager (#1234) upgraded review bot to v2.1.0 (#1908) Trading trait and deal with metadata in Mutate trait for nonfungibles_v2 (#1561) Add Runtime Missing Crate Descriptions (#1909) Switch to the release env (#1910) Bump paritytech/review-bot from 2.0.1 to 2.1.0 (#1924) Bump actions/checkout from 4.1.0 to 4.1.1 (#1925) Start BEEFY client by default for Polkadot nodes (#1913) ...
tdimitrov
pushed a commit
that referenced
this pull request
Oct 23, 2023
`cargo install` takes a long time in CI. We want to run it relatively frequently without chewing through so much compute (see paritytech/ci_cd#771) so I added automatic binary releases to the try-runtime-cli repo. A small added benefit is we can use it in our existing `on-runtime-upgrade` checks, which should cut their execution time by about half.
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Mar 26, 2024
…-> RialtoParachain bridge (paritytech#1898) * wrap confirmation and finality transactions into batch_all in RialtoParachain<>Millau * review comments
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Mar 27, 2024
…-> RialtoParachain bridge (paritytech#1898) * wrap confirmation and finality transactions into batch_all in RialtoParachain<>Millau * review comments
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
…-> RialtoParachain bridge (paritytech#1898) * wrap confirmation and finality transactions into batch_all in RialtoParachain<>Millau * review comments
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
…-> RialtoParachain bridge (paritytech#1898) * wrap confirmation and finality transactions into batch_all in RialtoParachain<>Millau * review comments
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
…-> RialtoParachain bridge (paritytech#1898) * wrap confirmation and finality transactions into batch_all in RialtoParachain<>Millau * review comments
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
…-> RialtoParachain bridge (paritytech#1898) * wrap confirmation and finality transactions into batch_all in RialtoParachain<>Millau * review comments
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
…-> RialtoParachain bridge (paritytech#1898) * wrap confirmation and finality transactions into batch_all in RialtoParachain<>Millau * review comments
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…-> RialtoParachain bridge (paritytech#1898) * wrap confirmation and finality transactions into batch_all in RialtoParachain<>Millau * review comments
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…-> RialtoParachain bridge (paritytech#1898) * wrap confirmation and finality transactions into batch_all in RialtoParachain<>Millau * review comments
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…-> RialtoParachain bridge (paritytech#1898) * wrap confirmation and finality transactions into batch_all in RialtoParachain<>Millau * review comments
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…-> RialtoParachain bridge (paritytech#1898) * wrap confirmation and finality transactions into batch_all in RialtoParachain<>Millau * review comments
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…-> RialtoParachain bridge (paritytech#1898) * wrap confirmation and finality transactions into batch_all in RialtoParachain<>Millau * review comments
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…-> RialtoParachain bridge (paritytech#1898) * wrap confirmation and finality transactions into batch_all in RialtoParachain<>Millau * review comments
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 10, 2024
…-> RialtoParachain bridge (paritytech#1898) * wrap confirmation and finality transactions into batch_all in RialtoParachain<>Millau * review comments
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 10, 2024
…-> RialtoParachain bridge (paritytech#1898) * wrap confirmation and finality transactions into batch_all in RialtoParachain<>Millau * review comments
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
…-> RialtoParachain bridge (#1898) * wrap confirmation and finality transactions into batch_all in RialtoParachain<>Millau * review comments
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo install
takes a long time in CI. We want to run it relatively frequently without chewing through so much compute (see https://github.com/paritytech/ci_cd/issues/771) so I added automatic binary releases to the try-runtime-cli repo.A small added benefit is we can use it in our existing
on-runtime-upgrade
checks, which should cut their execution time by about half.