Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ValidationError #1958

Closed
wants to merge 5 commits into from

Conversation

eagr
Copy link
Contributor

@eagr eagr commented Oct 20, 2023

closes #660
closes #661
closes #733

@eagr eagr requested review from a team October 20, 2023 15:25
@eagr eagr marked this pull request as draft October 20, 2023 15:25
@mrcnski
Copy link
Contributor

mrcnski commented Oct 31, 2023

Woah, awesome! I totally missed this. Is it ready for review @eagr ?

@eagr
Copy link
Contributor Author

eagr commented Nov 1, 2023

Not ready yet. I plan to continue on this after the artifact pr. :)

@mrcnski
Copy link
Contributor

mrcnski commented Nov 6, 2023

Hey @eagr, quick update from me! Getting #1685 merged is my highest priority right now, and as part of that PR I need to do a somewhat big error refactor. There hopefully won't be too many conflicts with this work, but it's pretty substantial, so consider this a heads-up! I apologize for the delays and any inconvenience, but after that PR goes in I'll be much more free to focus on other things, like reviewing the artifacts PR to unblock this one. :)

@eagr
Copy link
Contributor Author

eagr commented Nov 6, 2023

Isn't having merge conflicts the norm? :) Totally understand. And usually I wouldn't fixate on something. I'll just move on to the next thing, like green threads do, so no worries man.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4230235

@eagr
Copy link
Contributor Author

eagr commented Nov 20, 2023

Gonna redo this based on master as it's probably faster and easier to get right than trying to solve the conflicts. :) @mrcnski

@eagr eagr closed this Nov 20, 2023
@eagr eagr deleted the refactor-validation-error branch November 20, 2023 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
3 participants