Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically build and attach production and dev runtimes to GH releases #2054

Merged
merged 17 commits into from
Oct 27, 2023

Conversation

liamaharon
Copy link
Contributor

@liamaharon liamaharon commented Oct 27, 2023

Closes https://github.com/paritytech/release-engineering/issues/6

Adds a new Github Workflow which on a new release being created, builds and attaches all runtimes managed in this repository in two flavours:

  • dev-debug-build: Built with the try-runtime feature and has logging enabled
  • on-chain-release: Built with the regular old on-chain-release feature

The new Github Workflow could be extended in the future by the @paritytech/release-engineering team to fully automate the release process if they choose to, similar to how it is fully automated in the Fellowship repo (https://github.com/polkadot-fellows/runtimes/blob/main/.github/workflows/release.yml).

The on-chain-release did not exist for parachains, so I added it.


Tested on my fork:

@liamaharon liamaharon requested review from a team as code owners October 27, 2023 07:27
@bkchr bkchr added the R0-silent Changes should not be mentioned in any release notes label Oct 27, 2023
@liamaharon
Copy link
Contributor Author

liamaharon commented Oct 27, 2023

@PierreBesson could you please confirm if the dev debug runtimes have logging enabled as you requested in the issue?

Runtimes have been built on my fork https://github.com/liamaharon/polkadot-sdk/releases/tag/test-6

Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments to improve a bit but LGTM, thanks !

.github/workflows/build-and-attach-release-runtimes.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-attach-release-runtimes.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-attach-release-runtimes.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-attach-release-runtimes.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-attach-release-runtimes.yml Outdated Show resolved Hide resolved
@paritytech-ci paritytech-ci requested a review from a team October 27, 2023 07:49
liamaharon and others added 5 commits October 27, 2023 18:50
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
…m:paritytech/polkadot-sdk into liam-build-and-attach-runtimes-to-release
Copy link
Contributor

@seadanda seadanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits but LGTM

liamaharon and others added 3 commits October 27, 2023 19:42
Co-authored-by: Dónal Murray <donal.murray@parity.io>
…m:paritytech/polkadot-sdk into liam-build-and-attach-runtimes-to-release
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@PierreBesson
Copy link

LGTM

@liamaharon liamaharon merged commit a706171 into master Oct 27, 2023
113 of 114 checks passed
@liamaharon liamaharon deleted the liam-build-and-attach-runtimes-to-release branch October 27, 2023 23:23
s0me0ne-unkn0wn pushed a commit that referenced this pull request Oct 29, 2023
…ases (#2054)

Closes paritytech/release-engineering#6

Adds a new Github Workflow which on a new release being created, builds
and attaches all runtimes managed in this repository in two flavours:
- `dev-debug-build`: Built with the `try-runtime` feature and has
logging enabled
- `on-chain-release`: Built with the regular old `on-chain-release`
feature

The new Github Workflow could be extended in the future by the
@paritytech/release-engineering team to fully automate the release
process if they choose to, similar to how it is fully automated in the
Fellowship repo
(https://github.com/polkadot-fellows/runtimes/blob/main/.github/workflows/release.yml).

The `on-chain-release` did not exist for parachains, so I added it. 

---

Tested on my fork: 
- https://github.com/liamaharon/polkadot-sdk/actions/runs/6663773523
- https://github.com/liamaharon/polkadot-sdk/releases/tag/test-6

---------

Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
Co-authored-by: Dónal Murray <donal.murray@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants