Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review-bot: trigger only on review approvals #2289

Merged
merged 2 commits into from
Nov 13, 2023
Merged

review-bot: trigger only on review approvals #2289

merged 2 commits into from
Nov 13, 2023

Commits on Nov 13, 2023

  1. set review-bot to trigger only on review approvals 

    Moved the review event of review-bot to only be triggered in approvals.

Because we only update the required reviews when someone approves, this will stop the bot from immediately requesting a new review when someone comments or request changes
    @Bullrich
    Bullrich committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    a984fcd View commit details
    Browse the repository at this point in the history

  2. fixed small logic typo 

    Also added comment to explain the logic
    @Bullrich
    Bullrich committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    bdb8ca8 View commit details
    Browse the repository at this point in the history