Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds derive_impl to relay-chain and parachain runtimes #2476

Merged
merged 19 commits into from
Dec 5, 2023
Merged

Adds derive_impl to relay-chain and parachain runtimes #2476

merged 19 commits into from
Dec 5, 2023

Conversation

gupnik
Copy link
Contributor

@gupnik gupnik commented Nov 24, 2023 •
edited
Loading

Step in #171

This PR adds the following changes:

  1. Remove experimental from SoloChainDefaultConfig
  2. Add RelayChainDefaultConfig and ParaChainDefaultConfig that are currently same as the solo one, but can change over time as needed
  3. Adds derive_impl with the appropriate default config to relay and parachains

@gupnik gupnik added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Nov 24, 2023
@gupnik gupnik requested review from a team November 24, 2023 05:41
@paritytech-review-bot paritytech-review-bot bot requested review from a team November 24, 2023 05:42
bkchr
bkchr reviewed Nov 24, 2023
View reviewed changes
substrate/bin/node-template/runtime/src/lib.rs Outdated Show resolved Hide resolved
substrate/bin/node-template/runtime/src/lib.rs Outdated Show resolved Hide resolved
cumulus/parachain-template/runtime/src/lib.rs Outdated Show resolved Hide resolved
@paritytech-ci paritytech-ci requested review from a team November 24, 2023 23:29
bkchr
bkchr approved these changes Nov 28, 2023
View reviewed changes
substrate/frame/system/src/lib.rs Outdated Show resolved Hide resolved
@paritytech-review-bot paritytech-review-bot bot requested review from a team November 28, 2023 13:24
@gupnik gupnik enabled auto-merge (squash) December 5, 2023 01:29
@gupnik gupnik merged commit 6bab88c into master Dec 5, 2023
112 of 115 checks passed
@gupnik gupnik deleted the gupnik/derive-impl-updates branch December 5, 2023 03:01
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v1-5-0/5358/1

@github-actions github-actions bot mentioned this pull request Feb 19, 2024
Closed
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Closed
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@codekitz
Adds derive_impl to relay-chain and parachain runtimes (paritytech#2476)
cf7a9f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gupnik @Polkadot-Forum @ordian @franciscoaguirre @bkchr @codekitz