Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statement-distribution: Add tests for incoming acknowledgements #2498

Merged
merged 9 commits into from
Dec 5, 2023
Merged

statement-distribution: Add tests for incoming acknowledgements #2498

merged 9 commits into from
Dec 5, 2023

Commits on Nov 17, 2023

  1. statement-distribution: Add tests for incoming acknowledgements 

    `handle_incoming_acknowledgement` was never tested. You can verify that it is
covered now at this coverage report:

https://app.codecov.io/gh/mrcnski/polkadot-sdk/blob/master/polkadot%2Fnode%2Fnetwork%2Fstatement-distribution%2Fsrc%2Fv2%2Fmod.rs#L2485
    @mrcnski
    mrcnski committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    16d1287 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2023

  1. Refactor a bit (can roll with this in a future PR if it looks good)

    @mrcnski
    mrcnski committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    c60465e View commit details
    Browse the repository at this point in the history

  2. Test receiving another valid ack

    @mrcnski
    mrcnski committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    d8d5bfa View commit details
    Browse the repository at this point in the history

  3. Refactor existing test to show how much nicer the new functions are

    @mrcnski
    mrcnski committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    457b82f View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. remove unused dep

    @mrcnski
    mrcnski committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    b3b85b2 View commit details
    Browse the repository at this point in the history

  2. Rename target_group -> other_group 

    Multiple people expressed confusion over the previous naming. This new scheme
just keeps things more consistent and clear.
    @mrcnski
    mrcnski committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    27fe1eb View commit details
    Browse the repository at this point in the history

  3. change assert_peer_reported to macro

    @mrcnski
    mrcnski committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    168e69b View commit details
    Browse the repository at this point in the history

  4. Fix macro

    @mrcnski
    mrcnski committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    37faf84 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into mrcnski/statement-distribution-test-incomi… 

    …ng-ack
    @mrcnski
    mrcnski committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    2a6a710 View commit details
    Browse the repository at this point in the history