Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frame] #[pallet::composite_enum] improved variant count handling + removed pallet_balances's MaxHolds config #2657

Merged
merged 63 commits into from
Jan 31, 2024
Merged

[frame] #[pallet::composite_enum] improved variant count handling + removed pallet_balances's MaxHolds config #2657

merged 63 commits into from
Jan 31, 2024

Commits on Jan 5, 2024

  1. Test for MaxHolds

    @bkontur
    bkontur committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    746732c View commit details
    Browse the repository at this point in the history

  2. wip

    @bkontur
    bkontur committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    d1dba07 View commit details
    Browse the repository at this point in the history

  3. Dedicated test for composite_enum and variant count

    @bkontur
    bkontur committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    535a883 View commit details
    Browse the repository at this point in the history

  4. Fix HoldReason and FreezeReason variant count

    @bkontur
    bkontur committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    2e8a925 View commit details
    Browse the repository at this point in the history

  5. Fix macro for no composite enums

    @bkontur
    bkontur committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    b752f74 View commit details
    Browse the repository at this point in the history

  6. impl Get<u32> for RuntimeFreezeReason/RuntimeHoldReason

    @bkontur
    bkontur committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    80c685c View commit details
    Browse the repository at this point in the history

  7. Set all MaxHolds = RuntimeHoldReason and `MaxFreezes = RuntimeFreez… 

    …eReason`
    @bkontur
    bkontur committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    a2b272a View commit details
    Browse the repository at this point in the history

  8. ".git/.scripts/commands/fmt/fmt.sh"

    command-bot committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    694d230 View commit details
    Browse the repository at this point in the history

  9. Docs fix

    @bkontur
    bkontur committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    a0dd0a8 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Update substrate/frame/support/procedural/src/lib.rs 

    Co-authored-by: Bastian Köcher <git@kchr.de>
    @bkontur @bkchr
    bkontur and bkchr authored Jan 8, 2024
    Configuration menu
    Copy the full SHA
    71156bb View commit details
    Browse the repository at this point in the history

  2. Fix other places with Basti's suggestion

    @bkontur
    bkontur committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    2f3c31c View commit details
    Browse the repository at this point in the history

  3. Update substrate/frame/support/procedural/src/lib.rs 

    Co-authored-by: Bastian Köcher <git@kchr.de>
    @bkontur @bkchr
    bkontur and bkchr authored Jan 8, 2024
    Configuration menu
    Copy the full SHA
    6d6e75c View commit details
    Browse the repository at this point in the history

  4. Update substrate/frame/support/procedural/src/lib.rs 

    Co-authored-by: Bastian Köcher <git@kchr.de>
    @bkontur @bkchr
    bkontur and bkchr authored Jan 8, 2024
    Configuration menu
    Copy the full SHA
    b84cc1b View commit details
    Browse the repository at this point in the history

  5. Update substrate/frame/support/procedural/src/lib.rs 

    Co-authored-by: Bastian Köcher <git@kchr.de>
    @bkontur @bkchr
    bkontur and bkchr authored Jan 8, 2024
    Configuration menu
    Copy the full SHA
    4f5c9c8 View commit details
    Browse the repository at this point in the history

  6. fix

    @bkontur
    bkontur committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    b30e17e View commit details
    Browse the repository at this point in the history

  7. Update substrate/frame/support/procedural/src/construct_runtime/expan… 

    …d/hold_reason.rs

Co-authored-by: Bastian Köcher <git@kchr.de>
    @bkontur @bkchr
    bkontur and bkchr authored Jan 8, 2024
    Configuration menu
    Copy the full SHA
    b38ddb2 View commit details
    Browse the repository at this point in the history

  8. Update substrate/frame/support/procedural/src/construct_runtime/expan… 

    …d/hold_reason.rs

Co-authored-by: Bastian Köcher <git@kchr.de>
    @bkontur @bkchr
    bkontur and bkchr authored Jan 8, 2024
    Configuration menu
    Copy the full SHA
    8d9bdf0 View commit details
    Browse the repository at this point in the history

  9. pallet::balances replace MaxHolds with `VariantCountOf<T::Runtime… 

    …HoldReason>`
    @bkontur
    bkontur committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    9bde28f View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Removed unnecessery impl #scrate::traits::Get<u32> for Runtime*Reason

    @bkontur
    bkontur committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    f759563 View commit details
    Browse the repository at this point in the history

  2. Removed MaxHolds from everywhere

    @bkontur
    bkontur committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    635724e View commit details
    Browse the repository at this point in the history

  3. Fix after removed Get impl

    @bkontur
    bkontur committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    a32b0b0 View commit details
    Browse the repository at this point in the history

  4. Removed derive macro CompositeEnumVariantCount and replace with exp… 

    …and in-place
    @bkontur
    bkontur committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    f43412c View commit details
    Browse the repository at this point in the history

  5. fmt

    @bkontur
    bkontur committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    248790a View commit details
    Browse the repository at this point in the history

  6. One more revert for MaxFreezes

    @bkontur
    bkontur committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9faefd8 View commit details
    Browse the repository at this point in the history

  7. Add additional check for composite enums

    @bkontur
    bkontur committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    3c81275 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/master' into bko-max-holds-integ… 

    …rity-test
    @bkontur
    bkontur committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9b8aa8e View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Fix for multi-instance pallets when InstanceXYZ is not specified in… 

    … `construct_runtime`
    @bkontur
    bkontur committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    32cf3ff View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into bko-max-holds-integ… 

    …rity-test
    @bkontur
    bkontur committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    3a4a1ce View commit details
    Browse the repository at this point in the history

  3. Fix preimage tests

    @bkontur
    bkontur committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    bccc074 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. prdoc

    @bkontur
    bkontur committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    ba7df0b View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into bko-max-holds-integ… 

    …rity-test
    @bkontur
    bkontur committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    6778282 View commit details
    Browse the repository at this point in the history

  3. prdoc - change audience

    @bkontur
    bkontur committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    0959bea View commit details
    Browse the repository at this point in the history

  4. prdoc one more time

    @bkontur
    bkontur committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    c637145 View commit details
    Browse the repository at this point in the history

  5. removed empty line

    @bkontur
    bkontur committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    9eca694 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/master' into bko-max-holds-integ… 

    …rity-test
    @bkontur
    bkontur committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    44b0827 View commit details
    Browse the repository at this point in the history

  7. Hit me, baby, one more time...

    @bkontur
    bkontur committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    f4cfc2c View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Merge remote-tracking branch 'origin/master' into bko-max-holds-integ… 

    …rity-test
    @bkontur
    bkontur committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    5a1b161 View commit details
    Browse the repository at this point in the history

  2. Update substrate/frame/support/procedural/src/pallet/expand/mod.rs 

    Co-authored-by: Dónal Murray <donal.murray@parity.io>
    @bkontur @seadanda
    bkontur and seadanda authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    d557601 View commit details
    Browse the repository at this point in the history

  3. Update substrate/frame/support/procedural/src/pallet/expand/mod.rs 

    Co-authored-by: Dónal Murray <donal.murray@parity.io>
    @bkontur @seadanda
    bkontur and seadanda authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    48c3d37 View commit details
    Browse the repository at this point in the history

  4. Update prdoc/pr_2657.prdoc 

    Co-authored-by: Dónal Murray <donal.murray@parity.io>
    @bkontur @seadanda
    bkontur and seadanda authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    442f3fd View commit details
    Browse the repository at this point in the history

  5. Update substrate/frame/support/test/tests/composite_enum.rs 

    Co-authored-by: Dónal Murray <donal.murray@parity.io>
    @bkontur @seadanda
    bkontur and seadanda authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    abaf487 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/bko-max-holds-integrity-test' in… 

    …to bko-max-holds-integrity-test
    @bkontur
    bkontur committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    2358636 View commit details
    Browse the repository at this point in the history

  7. Removed unnecessary indexes from construct_runtime

    @bkontur
    bkontur committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    7d113e9 View commit details
    Browse the repository at this point in the history

  8. ".git/.scripts/commands/fmt/fmt.sh"

    command-bot committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    6a0289a View commit details
    Browse the repository at this point in the history

  9. Fmt? struct vs enum?

    @bkontur
    bkontur committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    0cb363a View commit details
    Browse the repository at this point in the history

  10. ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime… 

    …=dev --target_dir=substrate --pallet=pallet_balances
    command-bot committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    83e64fe View commit details
    Browse the repository at this point in the history

  11. ".git/.scripts/commands/bench/bench.sh" --subcommand=runtime --runtim… 

    …e=westend --target_dir=polkadot --pallet=pallet_balances
    command-bot committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    4342247 View commit details
    Browse the repository at this point in the history

  12. ".git/.scripts/commands/bench/bench.sh" --subcommand=runtime --runtim… 

    …e=rococo --target_dir=polkadot --pallet=pallet_balances
    command-bot committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    71c55c7 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'master' into bko-max-holds-integrity-test

    @bkontur
    bkontur authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    5af90e7 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Update prdoc/pr_2657.prdoc 

    Co-authored-by: gupnik <nikhilgupta.iitk@gmail.com>
    @bkontur @codekitz
    bkontur and codekitz authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    464af0c View commit details
    Browse the repository at this point in the history

  2. PR review fixes

    @bkontur
    bkontur committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    4015ea0 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into bko-max-holds-integ… 

    …rity-test
    @bkontur
    bkontur committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    c869313 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Merge branch 'master' into bko-max-holds-integrity-test

    @bkontur
    bkontur authored Jan 30, 2024
    Configuration menu
    Copy the full SHA
    77066c8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into bko-max-holds-integrity-test

    @bkontur
    bkontur authored Jan 30, 2024
    Configuration menu
    Copy the full SHA
    5380371 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into bko-max-holds-integ… 

    …rity-test
    @bkontur
    bkontur committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    01c39bf View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. ".git/.scripts/commands/bench-all/bench-all.sh" --pallet=pallet_balances

    command-bot committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    0ce9eca View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i… 

    …nto HEAD
    command-bot committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    3aeb0f8 View commit details
    Browse the repository at this point in the history

  3. ".git/.scripts/commands/bench-all/bench-all.sh" --pallet=pallet_balances

    command-bot committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    998ed0f View commit details
    Browse the repository at this point in the history

  4. ".git/.scripts/commands/bench-all/bench-all.sh" --pallet=pallet_balances

    command-bot committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    53b2f44 View commit details
    Browse the repository at this point in the history

  5. ".git/.scripts/commands/bench-all/bench-all.sh" --pallet=pallet_balances

    command-bot committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    e6552cc View commit details
    Browse the repository at this point in the history

  6. ".git/.scripts/commands/bench-all/bench-all.sh" --pallet=pallet_balances

    command-bot committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    2d6a3c4 View commit details
    Browse the repository at this point in the history

  7. ".git/.scripts/commands/bench-all/bench-all.sh" --pallet=pallet_balances

    command-bot committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    27a5723 View commit details
    Browse the repository at this point in the history

  8. ".git/.scripts/commands/bench-all/bench-all.sh" --pallet=pallet_balances

    command-bot committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    adbcace View commit details
    Browse the repository at this point in the history