-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable async backing on all testnet system chains #2949
Enable async backing on all testnet system chains #2949
Commits on Dec 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 277268d - Browse repository at this point
Copy the full SHA 277268dView commit details
Commits on Dec 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8876b0e - Browse repository at this point
Copy the full SHA 8876b0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d386c02 - Browse repository at this point
Copy the full SHA d386c02View commit details -
Configuration menu - View commit details
-
Copy full SHA for c12c82a - Browse repository at this point
Copy the full SHA c12c82aView commit details
Commits on Jan 8, 2024
-
Parametrize SlotDurations for system parachain tests (because of `moc…
Configuration menu - View commit details
-
Copy full SHA for f1b811d - Browse repository at this point
Copy the full SHA f1b811dView commit details
Commits on Jan 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5350101 - Browse repository at this point
Copy the full SHA 5350101View commit details -
Merge remote-tracking branch 'refs/remotes/origin/mrcnski/async-backi…
…ng-on-asset-hub-rococo' into mrcnski/async-backing-on-asset-hub-rococo
Configuration menu - View commit details
-
Copy full SHA for c07d887 - Browse repository at this point
Copy the full SHA c07d887View commit details
Commits on Jan 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1f07f6a - Browse repository at this point
Copy the full SHA 1f07f6aView commit details
Commits on Jan 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e7b57b8 - Browse repository at this point
Copy the full SHA e7b57b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ee2ced - Browse repository at this point
Copy the full SHA 1ee2cedView commit details -
Configuration menu - View commit details
-
Copy full SHA for 25073e9 - Browse repository at this point
Copy the full SHA 25073e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc48f64 - Browse repository at this point
Copy the full SHA bc48f64View commit details
Commits on Jan 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d4894cf - Browse repository at this point
Copy the full SHA d4894cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed50660 - Browse repository at this point
Copy the full SHA ed50660View commit details -
Merge branch 'mrcnski/async-backing-on-asset-hub-rococo' into mrcnski…
…/enable-async-backing-on-testnet-system-chains
Configuration menu - View commit details
-
Copy full SHA for fbd58e4 - Browse repository at this point
Copy the full SHA fbd58e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0672994 - Browse repository at this point
Copy the full SHA 0672994View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff9538f - Browse repository at this point
Copy the full SHA ff9538fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 23bb3bc - Browse repository at this point
Copy the full SHA 23bb3bcView commit details
Commits on Jan 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7b0ec8b - Browse repository at this point
Copy the full SHA 7b0ec8bView commit details
Commits on Jan 18, 2024
-
Introduce
BlockWeightsForAsyncBacking
and `MAXIMUM_BLOCK_WEIGHT_FOR……_ASYNC_BACKING` to bridges primitives (#2966) Fixes: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4943591
Configuration menu - View commit details
-
Copy full SHA for 42f5d1b - Browse repository at this point
Copy the full SHA 42f5d1bView commit details -
Update polkadot/node/subsystem-types/src/messages.rs
Co-authored-by: Dónal Murray <donal.murray@parity.io>
Configuration menu - View commit details
-
Copy full SHA for c6e85bd - Browse repository at this point
Copy the full SHA c6e85bdView commit details -
Update cumulus/polkadot-parachain/src/service.rs
Co-authored-by: Dónal Murray <donal.murray@parity.io>
Configuration menu - View commit details
-
Copy full SHA for 6b767f0 - Browse repository at this point
Copy the full SHA 6b767f0View commit details -
Update cumulus/polkadot-parachain/src/command.rs
Co-authored-by: Dónal Murray <donal.murray@parity.io>
Configuration menu - View commit details
-
Copy full SHA for 57442d7 - Browse repository at this point
Copy the full SHA 57442d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5cd6fa - Browse repository at this point
Copy the full SHA f5cd6faView commit details -
Configuration menu - View commit details
-
Copy full SHA for eb79b66 - Browse repository at this point
Copy the full SHA eb79b66View commit details
Commits on Jan 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for deea060 - Browse repository at this point
Copy the full SHA deea060View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3388f5f - Browse repository at this point
Copy the full SHA 3388f5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ff3316 - Browse repository at this point
Copy the full SHA 9ff3316View commit details
Commits on Jan 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8f79188 - Browse repository at this point
Copy the full SHA 8f79188View commit details -
Configuration menu - View commit details
-
Copy full SHA for 359968b - Browse repository at this point
Copy the full SHA 359968bView commit details -
Merge branch 'mrcnski/async-backing-on-asset-hub-rococo' into mrcnski…
…/enable-async-backing-on-testnet-system-chains
Configuration menu - View commit details
-
Copy full SHA for a34c909 - Browse repository at this point
Copy the full SHA a34c909View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7591656 - Browse repository at this point
Copy the full SHA 7591656View commit details
Commits on Jan 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9c133d0 - Browse repository at this point
Copy the full SHA 9c133d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c20f57 - Browse repository at this point
Copy the full SHA 1c20f57View commit details -
Merge remote-tracking branch 'refs/remotes/origin/mrcnski/enable-asyn…
…c-backing-on-testnet-system-chains' into mrcnski/enable-async-backing-on-testnet-system-chains
Configuration menu - View commit details
-
Copy full SHA for 424a19e - Browse repository at this point
Copy the full SHA 424a19eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b018a38 - Browse repository at this point
Copy the full SHA b018a38View commit details
Commits on Jan 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for efe15ff - Browse repository at this point
Copy the full SHA efe15ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac8fcb2 - Browse repository at this point
Copy the full SHA ac8fcb2View commit details
Commits on Jan 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f758b5a - Browse repository at this point
Copy the full SHA f758b5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ea5306 - Browse repository at this point
Copy the full SHA 7ea5306View commit details
Commits on Jan 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e1d812f - Browse repository at this point
Copy the full SHA e1d812fView commit details
Commits on Feb 1, 2024
-
Merge remote-tracking branch 'origin/master' into mrcnski/enable-asyn…
…c-backing-on-testnet-system-chains
Configuration menu - View commit details
-
Copy full SHA for 077e377 - Browse repository at this point
Copy the full SHA 077e377View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6de532d - Browse repository at this point
Copy the full SHA 6de532dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7834080 - Browse repository at this point
Copy the full SHA 7834080View commit details -
Merge remote-tracking branch 'origin/master' into mrcnski/enable-asyn…
…c-backing-on-testnet-system-chains
Configuration menu - View commit details
-
Copy full SHA for 0bc314f - Browse repository at this point
Copy the full SHA 0bc314fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a12ee76 - Browse repository at this point
Copy the full SHA a12ee76View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2dba7a - Browse repository at this point
Copy the full SHA f2dba7aView commit details -
Merge remote-tracking branch 'origin/mrcnski/enable-async-backing-on-…
…testnet-system-chains' into mrcnski/enable-async-backing-on-testnet-system-chains
Configuration menu - View commit details
-
Copy full SHA for f5c060d - Browse repository at this point
Copy the full SHA f5c060dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 71aef4a - Browse repository at this point
Copy the full SHA 71aef4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 771602e - Browse repository at this point
Copy the full SHA 771602eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9de5256 - Browse repository at this point
Copy the full SHA 9de5256View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab0097b - Browse repository at this point
Copy the full SHA ab0097bView commit details
Commits on Feb 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5db7a7e - Browse repository at this point
Copy the full SHA 5db7a7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42ac088 - Browse repository at this point
Copy the full SHA 42ac088View commit details -
Fix
new_session
benchmark inpallet_collator_selection
(#3189)Issue was discovered by enabling async backing on all parachains in [this PR](#2949). The reason it happened is because with the move to async backing, the `DAYS` and `HOURS` constants doubled compared to the [previously imported values from parachain_common](https://github.com/paritytech/polkadot-sdk/blob/5ba8921787609dddbabb8be3443186b65fdde190/cumulus/parachains/runtimes/assets/asset-hub-rococo/src/lib.rs#L78), which led to the [`Period`](https://github.com/paritytech/polkadot-sdk/blob/5db7a7e1438f518714a7b41793ed6eb01f5668f7/cumulus/parachains/runtimes/assets/asset-hub-rococo/src/lib.rs#L703) doubling. This matters because in `pallet_collator_selection::Config`, the [allowed period of inactivity for collators is a `Period`](https://github.com/paritytech/polkadot-sdk/blob/5db7a7e1438f518714a7b41793ed6eb01f5668f7/cumulus/parachains/runtimes/assets/asset-hub-rococo/src/lib.rs#L752). When a new session is initialized, candidates which don't meet the criteria [here](https://github.com/paritytech/polkadot-sdk/blob/5db7a7e1438f518714a7b41793ed6eb01f5668f7/cumulus/pallets/collator-selection/src/lib.rs#L868) are removed. The benchmark code [hardcoded](https://github.com/paritytech/polkadot-sdk/blob/5ba8921787609dddbabb8be3443186b65fdde190/cumulus/pallets/collator-selection/src/benchmarking.rs#L397) the last active block value which is safe from kick to the pervious value of a period, `1800`, with the chain starting at `0`. When running the check, `KickThreshold` was `1800`, so it would pass, but it obviously doesn't work if the `Period` isn't `1800`. This PR fixes the benchmark by setting the `new_block` value to `T::KickThreshold::get()`, which will work for any chosen `Period`. Opening this PR against the original branch to expedite the merge. Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Configuration menu - View commit details
-
Copy full SHA for 8bf9c79 - Browse repository at this point
Copy the full SHA 8bf9c79View commit details