Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit impl for XcmAssetTransfers trait #3022

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

franciscoaguirre
Copy link
Contributor

If an Executor is required in some pallet's config, a mock might be provided where Executor = (). () already implements ExecuteXcm, but not XcmAssetTransfers, which is also related. This PR just fixes that so you can skip having to create a whole xcm configuration, which is non-trivial right now.

@franciscoaguirre franciscoaguirre requested a review from a team as a code owner January 22, 2024 19:00
@franciscoaguirre franciscoaguirre added R0-silent Changes should not be mentioned in any release notes T6-XCM This PR/Issue is related to XCM. labels Jan 22, 2024
@franciscoaguirre
Copy link
Contributor Author

bot fmt

@command-bot
Copy link

command-bot bot commented Jan 22, 2024

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4999256 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-9f8a1189-afd9-4263-af15-8479944ecc7c to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jan 22, 2024

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4999256 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4999256/artifacts/download.

@franciscoaguirre franciscoaguirre added this pull request to the merge queue Jan 23, 2024
Merged via the queue into master with commit 1417a02 Jan 23, 2024
132 of 135 checks passed
@franciscoaguirre franciscoaguirre deleted the cis-impl-asset-transfer-for-unit branch January 23, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants