Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cumulus] Feature gates for rococo/westend related stuff in the parachains-common #3041

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Jan 24, 2024

This PR avoids automatically pulling rococo/westend runtime constants into the runtime by default. Usually, we have testnet runtimes dedicated to rococo or westend, and therefore, we don't need both dependencies. Additionally, it prevents pulling rococo/westend-related items into the polkadot-fellows repo, as seen in the Cargo.lock here and here.

@bkontur bkontur added R0-silent Changes should not be mentioned in any release notes T9-cumulus This PR/Issue is related to cumulus. labels Jan 24, 2024
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

cumulus/parachains/common/Cargo.toml Outdated Show resolved Hide resolved
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5015374

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 1/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5015373

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 3/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5015375

@bkontur bkontur added this pull request to the merge queue Jan 24, 2024
@georgepisaltu georgepisaltu removed this pull request from the merge queue due to a manual request Jan 24, 2024
@bkontur bkontur added this pull request to the merge queue Jan 24, 2024
Merged via the queue into master with commit a78ff7d Jan 24, 2024
124 of 125 checks passed
@bkontur bkontur deleted the bko-parachains-common-features branch January 24, 2024 14:02
@bkchr
Copy link
Member

bkchr commented Jan 24, 2024

The stuff in the crate that is only for the fellowship runtimes, should be put into a crate in the fellowship repo. Fellowship should really only depend on pallets on common structs, nothing that is specialized for any kind of chain.

@bkontur bkontur mentioned this pull request Jan 24, 2024
12 tasks
@bkontur
Copy link
Contributor Author

bkontur commented Jan 24, 2024

The stuff in the crate that is only for the fellowship runtimes, should be put into a crate in the fellowship repo. Fellowship should really only depend on pallets on common structs, nothing that is specialized for any kind of chain.

Actually, I didn't check other stuff inside (just that rococo/westend stuff). Afaik, parachains-common contains just a common specific-chain-agnostic utilities, but I see some stuff which could be cleaned up. I will continue here: #3054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T9-cumulus This PR/Issue is related to cumulus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants