statement-distribution: Ensure we deactivate leaves before activating #3042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As activation can fail, we ensure that we don't miss deactivation of leaves.
alexggh
approved these changes
Jan 24, 2024
sandreim
approved these changes
Jan 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
rphmeier
reviewed
Jan 24, 2024
| v2::handle_deactivate_leaves(state, &deactivated); | ||
| v2::handle_active_leaves_update(ctx, state, activated, mode).await?; |
There was a problem hiding this comment.
This may cause issues as ordering was somewhat sensitive here.
Reference counts for active leaves may drop to zero and then be incremented back to 1 again. It would be more reliable to just ensure that we handle_deactivate_leaves even if handle_active_leaves_update fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As activation can fail, we ensure that we don't miss deactivation of leaves.