refactor pvf security module #3047
Merged
+132
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@s0me0ne-unkn0wn I believe, labels I4-refactor, R0-silent and T0-node should be added :) |
|
Nice rework, thank you! Still fails on MacOS: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5017789 After that is fixed, I believe it's good to go. |
s0me0ne-unkn0wn
added
R0-silent
@s0me0ne-unkn0wn thank you for the review! I believe it is fixed now |
s0me0ne-unkn0wn
approved these changes
Jan 29, 2024
Merged
via the queue into
paritytech:master
with commit Feb 11, 2024
4883e14
123 of 125 checks passed
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #2321
securitymodule into a conditionally compiledamd64into x86-64 for consistency with conditional compilation guards and remove reference to a particular vendor