-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize/Deserialize trait implemented in no-std for XCM assets #3057
Merged
bkchr
merged 4 commits into
paritytech:master
from
moondance-labs:multiassets-serde-no-std
Jan 28, 2024
Merged
Serialize/Deserialize trait implemented in no-std for XCM assets #3057
bkchr
merged 4 commits into
paritytech:master
from
moondance-labs:multiassets-serde-no-std
Jan 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@KiChjang @franciscoaguirre we are experimenting with a pallet that would inject |
KiChjang
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be ok, I don't see major issues.
bkchr
approved these changes
Jan 28, 2024
Merged
via the queue into
paritytech:master
with commit Jan 28, 2024
de835f4
127 of 129 checks passed
al3mart
pushed a commit
that referenced
this pull request
Jan 29, 2024
Continues the work of paritytech/polkadot#7312. `MultiLocation` was modified to implement serialize in no-std in that PR, but not the assets types. This PR does the same for assets, and this also allows to inject them in pallets that require them in genesis.
fgamundi
added a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Feb 23, 2024
…itytech#3057) Continues the work of paritytech/polkadot#7312. `MultiLocation` was modified to implement serialize in no-std in that PR, but not the assets types. This PR does the same for assets, and this also allows to inject them in pallets that require them in genesis. # Conflicts: # polkadot/xcm/src/v4/asset.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues the work of paritytech/polkadot#7312.
MultiLocation
was modified to implement serialize in no-std in that PR, but not the assets types.This PR does the same for assets, and this also allows to inject them in pallets that require them in genesis.