Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize/Deserialize trait implemented in no-std for XCM assets #3057

Merged
merged 4 commits into from
Jan 28, 2024

Conversation

fgamundi
Copy link
Contributor

@fgamundi fgamundi commented Jan 25, 2024

Continues the work of paritytech/polkadot#7312. MultiLocation was modified to implement serialize in no-std in that PR, but not the assets types.
This PR does the same for assets, and this also allows to inject them in pallets that require them in genesis.

@fgamundi fgamundi requested a review from a team as a code owner January 25, 2024 09:46
@girazoki
Copy link
Contributor

@KiChjang @franciscoaguirre we are experimenting with a pallet that would inject AssetId in genesis and we need the serialize to be derived. This PR does that and adds it to pretty much all XCM types, is this something that is OK for you?

Copy link
Contributor

@KiChjang KiChjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok, I don't see major issues.

@bkchr bkchr added the T6-XCM This PR/Issue is related to XCM. label Jan 28, 2024
@bkchr bkchr added this pull request to the merge queue Jan 28, 2024
Merged via the queue into paritytech:master with commit de835f4 Jan 28, 2024
127 of 129 checks passed
al3mart pushed a commit that referenced this pull request Jan 29, 2024
Continues the work of paritytech/polkadot#7312.
`MultiLocation` was modified to implement serialize in no-std in that
PR, but not the assets types.
This PR does the same for assets, and this also allows to inject them in
pallets that require them in genesis.
@fgamundi fgamundi deleted the multiassets-serde-no-std branch January 29, 2024 07:57
fgamundi added a commit to moondance-labs/polkadot-sdk that referenced this pull request Feb 23, 2024
…itytech#3057)

Continues the work of paritytech/polkadot#7312.
`MultiLocation` was modified to implement serialize in no-std in that
PR, but not the assets types.
This PR does the same for assets, and this also allows to inject them in
pallets that require them in genesis.
# Conflicts:
#	polkadot/xcm/src/v4/asset.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants